Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Update filters on view initialization #1366

Merged
merged 1 commit into from
Sep 29, 2017
Merged

[RFR] Update filters on view initialization #1366

merged 1 commit into from
Sep 29, 2017

Conversation

floo51
Copy link
Contributor

@floo51 floo51 commented Sep 29, 2017

Fixes an issue where a pinned filter wouldn't filter with its initially selected value.

@Kmaschta
Copy link
Contributor

Does this PR fix this issue ? #1204

@floo51
Copy link
Contributor Author

floo51 commented Sep 29, 2017

No, I don't think defaultValue actually applies for filters.
We can still implement something like it with map and transform returning our default value where no value is given in the map function by instance.

@Kmaschta Kmaschta merged commit eb8b125 into master Sep 29, 2017
@Kmaschta Kmaschta deleted the fix-pinned-filter-initialization branch September 29, 2017 15:52
@tomy2105 tomy2105 mentioned this pull request Nov 24, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kmaschta Kmaschta Kmaschta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@floo51 @Kmaschta