Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DAG.to_dot when reducers have multiple outputs #3150

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Fix DAG.to_dot when reducers have multiple outputs #3150

merged 1 commit into from
Jun 16, 2022

Conversation

chaokunyang
Copy link
Contributor

What do these changes do?

This PR fix graph.to_dot when reducer has multiple outputs

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@chaokunyang chaokunyang requested a review from a team as a code owner June 15, 2022 13:08
@wjsi wjsi changed the title fix to_dot when reducer has multiple outputs Fix DAG.to_dot when reducers have multiple outputs Jun 16, 2022
wjsi
wjsi approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hekaisheng
hekaisheng approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hekaisheng hekaisheng merged commit 96ec5a9 into mars-project:master Jun 16, 2022
@wjsi wjsi added type: bug Something isn't working to be backported Indicate that the PR need to be backported to stable branch labels Jun 16, 2022
@wjsi wjsi added this to the v0.10.0a2 milestone Jun 16, 2022
wjsi pushed a commit to wjsi/mars that referenced this pull request Jun 16, 2022
@chaokunyang @wjsi
Fix DAG.to_dot when reducers have multiple outputs (mars-project#3150)
3790912
@wjsi wjsi mentioned this pull request Jun 16, 2022
Merged
@wjsi wjsi added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjsi wjsi wjsi approved these changes

@hekaisheng hekaisheng hekaisheng approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported type: bug Something isn't working
Projects
None yet
Milestone
v0.10.0a2
Development

Successfully merging this pull request may close these issues.
3 participants
@chaokunyang @wjsi @hekaisheng