Fix disabling chord normalization in formatters #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnversluis
force-pushed
the
fix-disabling-normalization-in-formatters
branch
from
cf5ce5a
to
e5b166a
Compare
martijnversluis
force-pushed
the
fix-disabling-normalization-in-formatters
branch
from
e5b166a
to
46e40e7
Compare
|
Code Climate has analyzed commit 46e40e7 and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When instantiating a formatter with option
normalizeChords: false, normalization should not be applied. This functionality was not implemented forChordProFormatterandChordsOverWordsFormatter.Related to #1166
Thanks to @ldelia for reporting.