Implement wildcards on the file list.

[Gui13]

This is done by searching for the '*' string in the file path, which is a sub-group of the whole "file glob" capabilities of Golang.

Fixes #176

Note: I believe we could add a full-glob support with regexes and so on, but this would mean either:

• passing the entire file names systematically through the filepath.Glob() regardless of their content
• or adding a flag telling the configuration to Glob() the files

The first is relatively easy, but I didn't want to go "full glob" if that's not desirable (which I'm not quite equiped to judge).
Your call though, I'm up to coding it.

[martin-helmich]

Thanks for your contribution! In general, 👍 from me. I've just added a few comments on some function signatures that I think could be streamlined and some things I feel should be pointed out in the documentation before merging this issue.

As to the "full glob support" question that you've raised in your initial comment -- I'm not leaning in any particular direction right now. I'd be fine with leaving it as-is for now (and add full-glob support later, if feature requests should arise); OTOH just passing every file name through Glob should also be relatively inexpensive (since glob expansion is only done during startup, and not continuously -- however, see also my discussion on that) and should also not break BC in any way.

[Gui13]

Hi @martin-helmich

Thanks for the comments, I agree with you on all of them, let's keep the scope simple right now.
For the dynamic addition of new files matching, I agree that monitoring the wildcard would involve a lot of things (inotify on all directories + filter for matching patterns), so I'll amend the readme with the limitations rather than launch a big implementation.

I've been swamped at work the last 2 weeks so I'll go back to this maybe next week.

[Gui13]

Ok I took the time to mount up the error. Tell me if the current state of the PR is ok for you!

[martin-helmich]

Code looks good to me. 👍 Pending the documentation update, I'll happily merge this. 🙂

[codeclimate]

Code Climate has analyzed commit d06cb06 and detected 0 issues on this pull request.

View more on Code Climate.

[Gui13]

Hi @martin-helmich ,

Sorry I got taken up by my reald world :)

I modified the documentation to add details about the glob being only evaluated at program start.

[martin-helmich]

👍 Thanks for the contribution!