Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to set bind address at startup #186

Merged
merged 1 commit into from
Mar 1, 2021
Merged

Add ability to set bind address at startup #186

merged 1 commit into from
Mar 1, 2021

Conversation

xelatirdan
Copy link
Contributor

Hello! Ability to set bind address add more flexibility in situations when we need run nginxlog-exporter with docker host network.

@codeclimate
Copy link

codeclimate bot commented Feb 28, 2021

Code Climate has analyzed commit dd748c3 and detected 0 issues on this pull request.

View more on Code Climate.

martin-helmich
martin-helmich approved these changes Mar 1, 2021
View reviewed changes
Copy link
Owner

@martin-helmich martin-helmich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on this. Just as a side note, you can already configure the listen address using the configuration file. But I agree that it cannot hurt to have this also configurable using a command-line flag. Thanks for your contribution. 🎉

@martin-helmich martin-helmich merged commit 2870493 into martin-helmich:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-helmich martin-helmich martin-helmich approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xelatirdan @martin-helmich