Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter generation improvements #41

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

Parameter generation improvements #41

wants to merge 5 commits into from

Conversation

martinruefenacht
Copy link
Owner

This addresses #38.

@martinruefenacht
Copy link
Owner Author

Currently this is producing 134 errorcodes again, because the argument_count and argument_list is not dereferenced correctly. All constant and function presence testing works though.

carsonwoods
carsonwoods requested changes Dec 18, 2019
View reviewed changes
lemonspotter/__main__.py Outdated Show resolved Hide resolved
lemonspotter/core/argument.py Outdated Show resolved Hide resolved
lemonspotter/core/function.py Show resolved Hide resolved
lemonspotter/core/function.py Outdated Show resolved Hide resolved
lemonspotter/core/function.py Outdated Show resolved Hide resolved
lemonspotter/core/function.py Outdated Show resolved Hide resolved
@martinruefenacht martinruefenacht mentioned this pull request Dec 18, 2019
Open
@martinruefenacht
Copy link
Owner Author

This works without crashes. Ideally we would replace malloc statements with char[...] for example. This should be addressed in #43 and #42.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carsonwoods carsonwoods carsonwoods approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinruefenacht @carsonwoods