Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for massfords/jaxb-visitor issue #4. #9

Closed
wants to merge 1 commit into from

Conversation

unserializable
Copy link

This prevents #4 (methods with duplicate signatures) from occurring. Cause of duplication remains unclear to me.

@massfords massfords closed this Jan 20, 2017
@massfords
Copy link
Owner

@unserializable - Check out the new branch named issue-4.

I used your XSD as a test case and saw that due to its nested types some of the generated classes were mistakenly being identified as external classes. This is why they were duplicated. I fixed the check in the discovery code.

If you're ok with having your XSD as a test case then I'll merge this branch over and cut a release.

@unserializable
Copy link
Author

Hey @massfords, thanks for the quick reaction!

I checked out issue-4 branch and found it working as expected with regard to inner static classes.

Feel very free to use that particular XSD, which is slightly modified "state provided publicly available XML resource without any usage restrictions" from https://riha.eesti.ee/riha/main/xml/oigusakt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants