-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 3.9 support #709
base: master
Are you sure you want to change the base?
Drop Python 3.9 support #709
Conversation
WalkthroughThe changes include updates to Python version requirements across multiple configuration files, enhancements to the GitHub Actions workflow, and formatting improvements in various test files. The workflow's fail-fast strategy was altered, and dependencies like Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant GitHub Actions
participant Codecov
participant Python Environment
User->>GitHub Actions: Trigger CI Workflow
GitHub Actions->>Python Environment: Run Tests with Python 3.10
Python Environment-->>GitHub Actions: Test Results
GitHub Actions->>Codecov: Report Coverage
Codecov-->>GitHub Actions: Coverage Report
GitHub Actions-->>User: CI Results
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
This reverts commit b100e39.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #709 +/- ##
==========================================
+ Coverage 81.02% 82.21% +1.19%
==========================================
Files 27 27
Lines 1586 1586
Branches 361 361
==========================================
+ Hits 1285 1304 +19
+ Misses 236 217 -19
Partials 65 65 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (15)
- .github/workflows/test.yml (2 hunks)
- README.md (1 hunks)
- pylintrc (1 hunks)
- pyproject.toml (5 hunks)
- tasks.py (1 hunks)
- tests/test_collections.py (1 hunks)
- tests/test_design_patterns.py (1 hunks)
- tests/test_dev.py (1 hunks)
- tests/test_fractions.py (1 hunks)
- tests/test_functools.py (1 hunks)
- tests/test_io.py (1 hunks)
- tests/test_json.py (1 hunks)
- tests/test_os.py (1 hunks)
- tests/test_shutil.py (9 hunks)
- tests/test_tempfile.py (1 hunks)
Files skipped from review due to trivial changes (13)
- README.md
- pylintrc
- tasks.py
- tests/test_collections.py
- tests/test_design_patterns.py
- tests/test_dev.py
- tests/test_fractions.py
- tests/test_functools.py
- tests/test_io.py
- tests/test_json.py
- tests/test_os.py
- tests/test_shutil.py
- tests/test_tempfile.py
Additional comments not posted (7)
.github/workflows/test.yml (3)
8-8
: Approved:fail-fast
strategy set to false.This change allows all jobs to run to completion, providing a complete picture of all test failures.
12-12
: Approved: Updated Python version matrix.The inclusion of Python 3.10 and removal of 3.9 aligns with the objective to drop Python 3.9 support.
33-33
: Approved: Codecov action updated to v4.Ensure to verify any changes in behavior or new features introduced by the new version.
pyproject.toml (4)
12-12
: Approved: Updated minimum Python version to 3.10.This change aligns with the objective to drop support for Python 3.9.
30-30
: Approved: Simplifiednumpy
version constraint.The constraint
numpy<2
ensures compatibility with versions below 2.0 while simplifying the versioning.
37-37
: Approved: Addedpydantic
as a dependency.This addition suggests enhanced data validation or settings management capabilities.
54-54
: Approved: Updatedblack
target version topy310
.This change aligns the formatting tools with the updated Python version requirement.
Summary
fail-fast
in CI test strategyFor a follow up PR: remove numpy < 2 pin
torch
(latest 2.4.0) doesn't work well with numpy for some reason on windows (looks like some module doesn't support NP2 yet, need to figure out which):To recreate: