Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2313: Moderation policies as rooms (ban lists) #2313

Merged
merged 4 commits into from
Nov 25, 2019
Merged

MSC2313: Moderation policies as rooms (ban lists) #2313

merged 4 commits into from
Nov 25, 2019

Conversation

ara4n
Copy link
Member

@ara4n ara4n commented Oct 5, 2019 •
edited
Loading

@ara4n ara4n added the proposal A matrix spec change proposal label Oct 5, 2019
KitsuneRal
KitsuneRal reviewed Oct 5, 2019
View reviewed changes
Copy link
Member

@KitsuneRal KitsuneRal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting and wording fixes.

proposals/2313-ban-lists.md Outdated Show resolved Hide resolved
proposals/2313-ban-lists.md Outdated Show resolved Hide resolved
proposals/2313-ban-lists.md Outdated Show resolved Hide resolved
proposals/2313-ban-lists.md Outdated Show resolved Hide resolved
proposals/2313-ban-lists.md Outdated Show resolved Hide resolved
proposals/2313-ban-lists.md Outdated Show resolved Hide resolved
proposals/2313-ban-lists.md Outdated Show resolved Hide resolved
@ara4n ara4n mentioned this pull request Oct 8, 2019
Closed
uhoreg
uhoreg approved these changes Oct 23, 2019
View reviewed changes
Copy link
Member

@uhoreg uhoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, modulo Kitsune's suggestions

@uhoreg
Copy link
Member

uhoreg commented Oct 24, 2019

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Oct 24, 2019 •
edited by dbkr
Loading

Team member @uhoreg has proposed to merge this. The next step is review by the rest of the tagged people:

No concerns currently listed.

Once at least 75% of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels Oct 24, 2019
@uhoreg @KitsuneRal
Apply suggestions from code review
a51805c 
Co-Authored-By: Kitsune Ral <Kitsune-Ral@users.sf.net>
dbkr
dbkr reviewed Nov 12, 2019
View reviewed changes
proposals/2313-ban-lists.md Outdated Show resolved Hide resolved
@turt2live turt2live changed the title MSC2313: Ban lists MSC2313: Moderation policies as rooms (ban lists) Nov 18, 2019
@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Nov 18, 2019
@mscbot
Copy link
Collaborator

mscbot commented Nov 18, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@turt2live turt2live mentioned this pull request Nov 18, 2019
Open
@mscbot mscbot added finished-final-comment-period and removed final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Nov 25, 2019
@mscbot
Copy link
Collaborator

mscbot commented Nov 25, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

@turt2live turt2live merged commit 2a82a5c into master Nov 25, 2019
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Jan 8, 2020
@turt2live turt2live self-assigned this Feb 13, 2020
turt2live added a commit that referenced this pull request Feb 13, 2020
@turt2live
Spec moderation policy rooms (MSC2313)
c7942d1 
MSC: #2313
@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Feb 13, 2020
@turt2live turt2live mentioned this pull request Feb 13, 2020
Merged
@turt2live
Copy link
Member

Spec PR: #2434

@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Feb 18, 2020
@turt2live
Copy link
Member

Merged 🎉

@turt2live turt2live added the kind:core MSC which is critical to the protocol's success label Apr 20, 2020
@jplatte jplatte mentioned this pull request Jun 5, 2020
Closed
19 tasks
erkinalp
erkinalp reviewed Nov 14, 2020
View reviewed changes
proposals/2313-moderation-policy-rooms.md
* Is a room...
* Applied to a user: The user should leave the room and not join it
([MSC2270](https://github.com/matrix-org/matrix-doc/pull/2270)-style ignore).
* Applied to a room: No-op because a room cannot ban itself.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this equivalent to tombstone instead.

proposals/2313-moderation-policy-rooms.md
a simple implementation is as follows:

* Is a user...
* Applied to a user: The user should be added to the subscriber's ignore list.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block list is more preferrable.

@matrix-org matrix-org locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbkr dbkr dbkr left review comments

@turt2live turt2live turt2live left review comments

@erkinalp erkinalp erkinalp left review comments

@KitsuneRal KitsuneRal KitsuneRal approved these changes

@uhoreg uhoreg uhoreg approved these changes

Assignees

@turt2live turt2live

Labels
disposition-merge kind:core MSC which is critical to the protocol's success merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ara4n @uhoreg @mscbot @turt2live @dbkr @erkinalp @KitsuneRal