Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread List API #1368

Merged
merged 21 commits into from
Feb 15, 2022
Merged

Thread List API #1368

merged 21 commits into from
Feb 15, 2022

Conversation

ismailgulek
Copy link
Contributor

@ismailgulek ismailgulek mentioned this pull request Feb 11, 2022
Merged
@ismailgulek ismailgulek changed the title Thread List Api Thread List API Feb 11, 2022
stefanceriu
stefanceriu requested changes Feb 14, 2022
View reviewed changes
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a couple of comments 👍

MatrixSDK/Contrib/Swift/MXRestClient.swift Show resolved Hide resolved
MatrixSDK/Data/Store/MXMemoryStore/MXMemoryStore.m Outdated Show resolved Hide resolved
MatrixSDK/Data/Store/MXStore.h Outdated Show resolved Hide resolved
MatrixSDK/JSONModels/Event/MXEventRelationThread.h Outdated Show resolved Hide resolved
MatrixSDK/JSONModels/Event/MXEventRelationThread.h Outdated Show resolved Hide resolved
MatrixSDK/MXRestClient.m Outdated Show resolved Hide resolved
MatrixSDK/Threads/MXThreadModel.swift Show resolved Hide resolved
MatrixSDK/Threads/MXThreadingService.swift Outdated Show resolved Hide resolved
stefanceriu
stefanceriu approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

MatrixSDK/Threads/MXThreadingService.swift Show resolved Hide resolved
@ismailgulek ismailgulek merged commit cfec79a into develop Feb 15, 2022
@ismailgulek ismailgulek deleted the ismail/5540_thread_list branch February 15, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanceriu stefanceriu stefanceriu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ismailgulek @stefanceriu