Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test fallback screensharing #2659

Merged
merged 5 commits into from
Sep 9, 2022
Merged

Test fallback screensharing #2659

merged 5 commits into from
Sep 9, 2022

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Sep 9, 2022 •
edited by github-actions bot
Loading

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@dbkr dbkr added the T-Task Tasks for the team like planning label Sep 9, 2022
@dbkr dbkr requested a review from a team as a code owner September 9, 2022 16:45
SimonBrandner
SimonBrandner reviewed Sep 9, 2022
View reviewed changes
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

SimonBrandner
SimonBrandner approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though CI seems unhappy

@dbkr dbkr merged commit 00629e6 into robertlong/group-call Sep 9, 2022
@dbkr dbkr deleted the dbkr/test_fallback_screenshare branch September 9, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonBrandner SimonBrandner SimonBrandner approved these changes

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbkr @SimonBrandner