Add tests for redaction

matrix-org · Aug 27, 2024 · 6ce4cc8 · 6ce4cc8
1 parent 54f9723
commit 6ce4cc8
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 8 deletions.
diff --git a/test/components/views/right_panel/PinnedMessagesCard-test.tsx b/test/components/views/right_panel/PinnedMessagesCard-test.tsx
@@ -20,7 +20,6 @@ import { mocked, MockedObject } from "jest-mock";
 import {
     MatrixEvent,
     RoomStateEvent,
-    IEvent,
     Room,
     IMinimalEvent,
     EventType,
@@ -266,9 +265,8 @@ describe("<PinnedMessagesCard />", () => {
             // Redacted messages are unpinnable
             const pin = mkEvent({
                 event: true,
-                type: EventType.RoomMessage,
+                type: EventType.RoomCreate,
                 content: {},
-                unsigned: { redacted_because: {} as unknown as IEvent },
                 room: "!room:example.org",
                 user: "@alice:example.org",
             });
@@ -280,9 +278,8 @@ describe("<PinnedMessagesCard />", () => {
             // Redacted messages are unpinnable
             const pin = mkEvent({
                 event: true,
-                type: EventType.RoomMessage,
+                type: EventType.RoomCreate,
                 content: {},
-                unsigned: { redacted_because: {} as unknown as IEvent },
                 room: "!room:example.org",
                 user: "@alice:example.org",
             });

diff --git a/test/utils/PinningUtils-test.ts b/test/utils/PinningUtils-test.ts
@@ -75,15 +75,27 @@ describe("PinningUtils", () => {
         ).mockReturnValue(true);
     });
 
-    describe("isPinnable", () => {
+    describe("isUnpinnable", () => {
         test.each(PinningUtils.PINNABLE_EVENT_TYPES)("should return true for pinnable event types", (eventType) => {
             const event = makePinEvent({ type: eventType });
-            expect(PinningUtils.isPinnable(event)).toBe(true);
+            expect(PinningUtils.isUnpinnable(event)).toBe(true);
         });
 
         test("should return false for a non pinnable event type", () => {
             const event = makePinEvent({ type: EventType.RoomCreate });
-            expect(PinningUtils.isPinnable(event)).toBe(false);
+            expect(PinningUtils.isUnpinnable(event)).toBe(false);
+        });
+
+        test("should return true for a redacted event", () => {
+            const event = makePinEvent({ unsigned: { redacted_because: "because" as unknown as IEvent } });
+            expect(PinningUtils.isUnpinnable(event)).toBe(true);
+        });
+    });
+
+    describe("isPinnable", () => {
+        test.each(PinningUtils.PINNABLE_EVENT_TYPES)("should return true for pinnable event types", (eventType) => {
+            const event = makePinEvent({ type: eventType });
+            expect(PinningUtils.isPinnable(event)).toBe(true);
         });
 
         test("should return false for a redacted event", () => {