Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add Element call related functionality to new room header #12091

Merged
merged 27 commits into from
Jan 31, 2024
Merged

Add Element call related functionality to new room header #12091

merged 27 commits into from
Jan 31, 2024

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Dec 27, 2023 •
edited
Loading

This is needed to reasonably use element call with the new header.

This changes the following for the new room header:

  • add chat button during call.
  • show close lobby button in lobby.
  • show "join" button if session exists.
  • allow to toggle call <-> timeline during call with call button.
  • Fixes calls not beeing joinable due to Ongoing.Call with new room header.
  • Fixes calls not beeing joinable due to missing permissions (EC calls only need call member event permissions. So it is possible to start a call if only those are present)

Fixes: element-hq/element-web#26764

Compound style for join button in call notify toast.

Signed-off-by: Timo K toger5@hotmail.de

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

✨ Features

@toger5 toger5 requested a review from a team as a code owner December 27, 2023 18:54
@toger5 toger5 added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Dec 27, 2023
@toger5 toger5 marked this pull request as draft December 27, 2023 19:42
@toger5
New room header
fac8317 
 - add chat button during call
 - close lobby button in lobby
 - join button if session exists
 - allow to toggle call <-> timeline during call with call button

Compound style for join button in call notify toast.

Signed-off-by: Timo K <toger5@hotmail.de>
@toger5
dont show start call, join button in video rooms.
7c328fe 
Signed-off-by: Timo K <toger5@hotmail.de>
@toger5 toger5 force-pushed the toger5/call-new-room-header branch from e385de2 to 7c328fe Compare January 17, 2024 11:59
@toger5
Make active call check based on participant count
fe0472e 
Not based on available call object

Signed-off-by: Timo K <toger5@hotmail.de>
@toger5
fix room header tests
d11c4a7 
Signed-off-by: Timo K <toger5@hotmail.de>
@toger5
fix room header tests
d5a2525 
Signed-off-by: Timo K <toger5@hotmail.de>
@toger5
remove chat button test for displaying.
0aa5e00 
Chat button display logic is now part of the RoomHeader.

Signed-off-by: Timo K <toger5@hotmail.de>
@toger5
remove duplicate notification Tread icon
992f43e 
Signed-off-by: Timo K <toger5@hotmail.de>
@toger5 toger5 marked this pull request as ready for review January 24, 2024 13:22
@toger5 toger5 requested a review from robintown January 26, 2024 09:03
@toger5
Merge branch 'develop' into toger5/call-new-room-header
f8f105e 
Signed-off-by: Timo K <toger5@hotmail.de>
@toger5
fix event shiftKey may be undefined
aeecf8d 
Signed-off-by: Timo K <toger5@hotmail.de>
@toger5
more lobby time before timeout
5373658 
only await sticky promise on becoming sticky.

Signed-off-by: Timo K <toger5@hotmail.de>
robintown
robintown reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is coming along, though I still have a couple more nits before I'm comfortable merging it

src/components/views/rooms/RoomHeader.tsx Outdated Show resolved Hide resolved
src/components/views/rooms/RoomHeader.tsx Outdated Show resolved Hide resolved
src/components/views/rooms/RoomHeader.tsx Show resolved Hide resolved
src/hooks/room/useRoomCall.ts Outdated Show resolved Hide resolved
src/models/Call.ts Outdated Show resolved Hide resolved
@toger5
review
5ac670c 
Signed-off-by: Timo K <toger5@hotmail.de>
@toger5
fix translation typo
2f6dfde 
Signed-off-by: Timo K <toger5@hotmail.de>
@toger5 toger5 added this pull request to the merge queue Jan 31, 2024
Merged via the queue into develop with commit 73b1623 Jan 31, 2024
22 checks passed
@toger5 toger5 deleted the toger5/call-new-room-header branch January 31, 2024 15:41
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Feb 14, 2024
@bmwiedemann
Update element-web to version 1.11.58 / rev 50 via SR 1146558
1a8457b 
https://build.opensuse.org/request/show/1146558
by user dheidler + anag+factory
- Version 1.11.58
  ## ✨ Features

   * 🦀  🔒 **The flag to enable the Rust crypto implementation is now set to `true` by default. This means that without any additional configuration every new login will use the new cryptography implementation.**
  * Add Element call related functionality to new room header (matrix-org/matrix-react-sdk#12091). Contributed by @toger5.
  * Add labs flag for Threads Activity Centre (matrix-org/matrix-react-sdk#12137). Contributed by @florianduros.
  * Refactor element call lobby + skip lobby (matrix-org/matrix-react-sdk#12057). Contributed by @toger5.
  * Hide the "Message" button in the sidebar if the CreateRooms components should not be shown (https://github.com/matrix-org/matrix-react
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Feb 14, 2024
@bmwiedemann
Update element-desktop to version 1.11.58 / rev 51 via SR 1146559
787af6e 
https://build.opensuse.org/request/show/1146559
by user dheidler + anag+factory
- Version 1.11.58
  * 🦀  🔒 **The flag to enable the Rust crypto implementation is now set to `true` by default. This means that without any additional configuration every new login will use the new cryptography implementation.**
  * Add Element call related functionality to new room header (matrix-org/matrix-react-sdk#12091). Contributed by @toger5.
  * Add labs flag for Threads Activity Centre (matrix-org/matrix-react-sdk#12137). Contributed by @florianduros.
  * Refactor element call lobby + skip lobby (matrix-org/matrix-react-sdk#12057). Contributed by @toger5.
  * Hide the "Message" button in the sidebar if the CreateRooms components should not be shown (matrix-org/matrix-react-sdk#9271). Con
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Mar 3, 2024
@Midar
Update chat/element-web to 1.11.59
16e3e38 
Changes in [1.11.59](https://github.com/element-hq/element-web/releases/tag/v1.11.59) (2024-02-27)
==================================================================================================
## 🦖 Deprecations

* Enable custom themes to theme Compound ([#12240](matrix-org/matrix-react-sdk#12240)). Contributed by @robintown.
* Remove welcome bot `welcome_user_id` support ([#12153](matrix-org/matrix-react-sdk#12153)). Contributed by @t3chguy.

## ✨ Features

* Ignore activity in TAC ([#12269](matrix-org/matrix-react-sdk#12269)). Contributed by @florianduros.
* Use browser's font size instead of hardcoded `16px` as root font size ([#12246](matrix-org/matrix-react-sdk#12246)). Contributed by @florianduros.
* Revert "Use Compound primary colors for most actions" ([#12264](matrix-org/matrix-react-sdk#12264)). Contributed by @florianduros.
* Revert "Refine menu, toast, and popover colors" ([#12263](matrix-org/matrix-react-sdk#12263)). Contributed by @florianduros.
* Fix Native OIDC for Element Desktop ([#12253](matrix-org/matrix-react-sdk#12253)). Contributed by @t3chguy.
* Improve client metadata used for OIDC dynamic registration ([#12257](matrix-org/matrix-react-sdk#12257)). Contributed by @t3chguy.
* Refine menu, toast, and popover colors ([#12247](matrix-org/matrix-react-sdk#12247)). Contributed by @robintown.
* Call the AsJson forms of import and exportRoomKeys ([#12233](matrix-org/matrix-react-sdk#12233)). Contributed by @andybalaam.
* Use Compound primary colors for most actions ([#12241](matrix-org/matrix-react-sdk#12241)). Contributed by @robintown.
* Enable redirected media by default ([#12142](matrix-org/matrix-react-sdk#12142)). Contributed by @turt2live.
* Reduce TAC width by `16px` ([#12239](matrix-org/matrix-react-sdk#12239)). Contributed by @florianduros.
* Pop out of Threads Activity Centre ([#12136](matrix-org/matrix-react-sdk#12136)). Contributed by @florianduros.
* Use new semantic tokens for username colors ([#12209](matrix-org/matrix-react-sdk#12209)). Contributed by @robintown.

## 🐛 Bug Fixes

* [Backport staging] Fix spurious session corruption error ([#12287](matrix-org/matrix-react-sdk#12287)). Contributed by @RiotRobot.
* Fix the space panel getting bigger when gaining a scroll bar ([#12267](matrix-org/matrix-react-sdk#12267)). Contributed by @dbkr.
* Fix gradients spacings on the space panel ([#12262](matrix-org/matrix-react-sdk#12262)). Contributed by @dbkr.
* Remove hardcoded `Element` in tac labs description ([#12266](matrix-org/matrix-react-sdk#12266)). Contributed by @florianduros.
* Fix branding in "migrating crypto" message ([#12265](matrix-org/matrix-react-sdk#12265)). Contributed by @richvdh.
* Use h1 as first heading in dialogs ([#12250](matrix-org/matrix-react-sdk#12250)). Contributed by @dbkr.
* Fix forced lowercase username in login/registration flows ([#9329](matrix-org/matrix-react-sdk#9329)). Contributed by @vrifox.
* Update the TAC indicator on event decryption ([#12243](matrix-org/matrix-react-sdk#12243)). Contributed by @dbkr.
* Fix OIDC delegated auth account url check ([#12242](matrix-org/matrix-react-sdk#12242)). Contributed by @t3chguy.
* New Header edgecase fixes: Close lobby button not shown, disable join button in various places, more... ([#12235](matrix-org/matrix-react-sdk#12235)). Contributed by @toger5.
* Fix TAC button alignment when expanded ([#12238](matrix-org/matrix-react-sdk#12238)). Contributed by @florianduros.
* Fix tooltip behaviour in TAC ([#12236](matrix-org/matrix-react-sdk#12236)). Contributed by @florianduros.



Changes in [1.11.58](https://github.com/element-hq/element-web/releases/tag/v1.11.58) (2024-02-13)
==================================================================================================
## ✨ Features

 * 🦀  🔒 **The flag to enable the Rust crypto implementation is now set to `true` by default. This means that without any additional configuration every new login will use the new cryptography implementation.**
* Add Element call related functionality to new room header ([#12091](matrix-org/matrix-react-sdk#12091)). Contributed by @toger5.
* Add labs flag for Threads Activity Centre ([#12137](matrix-org/matrix-react-sdk#12137)). Contributed by @florianduros.
* Refactor element call lobby + skip lobby ([#12057](matrix-org/matrix-react-sdk#12057)). Contributed by @toger5.
* Hide the "Message" button in the sidebar if the CreateRooms components should not be shown ([#9271](matrix-org/matrix-react-sdk#9271)). Contributed by @dhenneke.
* Add notification dots to thread summary icons ([#12146](matrix-org/matrix-react-sdk#12146)). Contributed by @dbkr.

## 🐛 Bug Fixes

* [Backport staging] Fix the StorageManger detecting a false positive consistency check when manually migrating to rust from labs ([#12230](matrix-org/matrix-react-sdk#12230)). Contributed by @RiotRobot.
* Fix logout can take ages ([#12191](matrix-org/matrix-react-sdk#12191)). Contributed by @BillCarsonFr.
* Fix `Mark all as read` in settings ([#12205](matrix-org/matrix-react-sdk#12205)). Contributed by @florianduros.
* Fix default thread notification of the new RoomHeader ([#12194](matrix-org/matrix-react-sdk#12194)). Contributed by @florianduros.
* Fix display of room notification debug info ([#12183](matrix-org/matrix-react-sdk#12183)). Contributed by @dbkr.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robintown robintown robintown approved these changes

Assignees
No one assigned
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No chat right hand panel with new room header
2 participants
@toger5 @robintown