Don't expect monkeypatched nacl.signing.SigningKey instances #16
Labels
Comments
DMRobertson
pushed a commit
to matrix-org/synapse
that referenced
this issue
Jan 10, 2022
* Deal with mypy errors w/ type-hinted pynacl 1.5.0 Fixes #11644. I really don't like that we're monkey patching pynacl SignedKey instances with alg and version objects. But I'm too scared to make the changes necessary right now. (Ideally I would replace `signedjson.types.SingingKey` with a runtime class which wraps or inherits from `nacl.signing.SigningKey`.) C.f. matrix-org/python-signedjson#16
reivilibre
pushed a commit
to matrix-org/synapse
that referenced
this issue
Jan 12, 2022
* Deal with mypy errors w/ type-hinted pynacl 1.5.0 Fixes #11644. I really don't like that we're monkey patching pynacl SignedKey instances with alg and version objects. But I'm too scared to make the changes necessary right now. (Ideally I would replace `signedjson.types.SingingKey` with a runtime class which wraps or inherits from `nacl.signing.SigningKey`.) C.f. matrix-org/python-signedjson#16
babolivier
pushed a commit
to matrix-org/synapse-dinsic
that referenced
this issue
Jan 26, 2022
* Deal with mypy errors w/ type-hinted pynacl 1.5.0 Fixes #11644. I really don't like that we're monkey patching pynacl SignedKey instances with alg and version objects. But I'm too scared to make the changes necessary right now. (Ideally I would replace `signedjson.types.SingingKey` with a runtime class which wraps or inherits from `nacl.signing.SigningKey`.) C.f. matrix-org/python-signedjson#16
babolivier
pushed a commit
to matrix-org/synapse-dinsic
that referenced
this issue
Jan 26, 2022
* Deal with mypy errors w/ type-hinted pynacl 1.5.0 Fixes #11644. I really don't like that we're monkey patching pynacl SignedKey instances with alg and version objects. But I'm too scared to make the changes necessary right now. (Ideally I would replace `signedjson.types.SingingKey` with a runtime class which wraps or inherits from `nacl.signing.SigningKey`.) C.f. matrix-org/python-signedjson#16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A nicer way to fix matrix-org/synapse#11714 (imo)
(key: nacl.signing.SigningKey, alg: str, version: str). Either inherit fromnacl.signing.SigningKeyor introduce a new wrapper.signedjson.types.SigningKeyto accept this new data type.The text was updated successfully, but these errors were encountered: