Fix persist_events to stop leaking opentracing contexts (#10193)

matrix-org · Jun 17, 2021 · 52c60bd · 52c60bd
1 parent 18edc9a
commit 52c60bd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/changelog.d/10193.misc b/changelog.d/10193.misc
@@ -0,0 +1 @@
+Improve OpenTracing for event persistence.
diff --git a/synapse/storage/persist_events.py b/synapse/storage/persist_events.py
@@ -111,7 +111,7 @@ class _EventPersistQueueItem:
     backfilled: bool
     deferred: ObservableDeferred
 
-    parent_opentracing_span_contexts: List = []
+    parent_opentracing_span_contexts: List = attr.ib(factory=list)
     """A list of opentracing spans waiting for this batch"""
 
     opentracing_span_context: Any = None