Fix a stale comment in get_room_version_id_txn. (#12969)

matrix-org · Jun 7, 2022 · d2fd7f7 · d2fd7f7
1 parent 9dc3293
commit d2fd7f7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/changelog.d/12969.misc b/changelog.d/12969.misc
@@ -0,0 +1 @@
+Fix an inaccurate comment.
diff --git a/synapse/storage/databases/main/state.py b/synapse/storage/databases/main/state.py
@@ -127,13 +127,8 @@ def get_room_version_id_txn(self, txn: LoggingTransaction, room_id: str) -> str:
             NotFoundError: if the room is unknown
         """
 
-        # First we try looking up room version from the database, but for old
-        # rooms we might not have added the room version to it yet so we fall
-        # back to previous behaviour and look in current state events.
-        #
         # We really should have an entry in the rooms table for every room we
-        # care about, but let's be a bit paranoid (at least while the background
-        # update is happening) to avoid breaking existing rooms.
+        # care about, but let's be a bit paranoid.
         room_version = self.db_pool.simple_select_one_onecol_txn(
             txn,
             table="rooms",