Display name limit doesn't apply to per-room display names

[babolivier]

As per discussion in Matrix HQ, it seems like Synapse's limit to display name length doesn't apply to per-room display names.

[anoadragon453]

This would just be adding a length check to update_membership_locked that would fail the request if the length was too long. Similar to where we prevent per-room profile changes entirely:

synapse/synapse/handlers/room_member.py

Lines 358 to 365 in 6633a40

	if (
	not self.allow_per_room_profiles and not is_requester_server_notices_user
	) or requester.shadow_banned:
	# Strip profile data, knowing that new profile data will be added to the
	# event's content in event_creation_handler.create_event() using the target's
	# global profile.
	content.pop("displayname", None)
	content.pop("avatar_url", None)

[b-thebest]

Can I work on this issue ??

[anoadragon453]

@b-thebest Of course!

[b-thebest]

Please assign this task to me

…

On Thu, Mar 4, 2021, 4:16 PM Andrew Morgan ***@***.***> wrote: @b-thebest <https://github.com/b-thebest> Of course! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9236 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJ6VVH6XNBI3LFH4NYE7RALTB5QIVANCNFSM4WVAWFJA> .

[arya2331]

is someone still working on it? or I can do this?

[b-thebest]

I am working on it

…

On Thu, Apr 15, 2021, 10:23 PM Rishabh Arya ***@***.***> wrote: is someone still working on it? or I can do this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9236 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJ6VVH67RZKATTCVMYX2J7DTI4KYHANCNFSM4WVAWFJA> .

[richvdh]

@b-thebest do you have any idea of when you expect to make some progress on it? I don't think it's a big job and if others are ready to pick it up it might be nice to let them do so.

[b-thebest]

It was not in list of task assigned to me, that's why I was unable to do it. I will do it now asap

…

On Thu, Apr 15, 2021, 10:55 PM Richard van der Hoff < ***@***.***> wrote: @b-thebest <https://github.com/b-thebest> do you have any idea of when you expect to make some progress on it? I don't think it's a big job and if others are ready to pick it up it might be nice to let them do so. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9236 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJ6VVH6NLFAELDLI5ZCNNE3TI4OPTANCNFSM4WVAWFJA> .

[anoadragon453]

Hey @b-thebest, have you been able to make any progress on this?

[b-thebest]

Yes I was working on it. Sorry for being late, during past days my health conditions were not good that's why I was unable to complete it. From today I will take it on and try to complete it as soon as possible

[richvdh]

As is normal in open-source projects, we don't generally "assign" issues to individual contributors, and you shouldn't consider this a prerequisite to start work on it.

[lukasdenk]

@Azrenbeth Should this issue still be open? According to #10654 the issue is solved.