This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fix providing a RoomStreamToken
instance to _notify_app_services_ephemeral
#11137
Merged
Commits on Oct 20, 2021
-
Fix providing a RoomStreamToken instance to _notify_app_services_ephe…
…meral Previously, if a RoomStreamToken object were provided, new_token would be set to `None`. In the same changeset, which was intended to prevent mypy from failing, `_notify_app_services_ephemeral` was configured to allow `new_token` to be an Optional[int] (559974f). However, if `None` is provided, `_notify_app_services_ephemeral` will end up passing `None` to `set_type_stream_id_for_appservice`, which will effectively clear each appservice's stream token for the given `stream_key`. This seems like a bug to do every time we have a RoomStreamToken rather than an int. Instead, I'm converting the RoomStreamToken to an int using RoomStreamToken.stream. I think this is the right way to convert to an int. If RoomStreamToken this ends up being a vector clock, `stream` will be the minimum stream token amongst all workers... which I think is fine?
Configuration menu - View commit details
-
Copy full SHA for 4d6af01 - Browse repository at this point
Copy the full SHA 4d6af01View commit details -
Configuration menu - View commit details
-
Copy full SHA for b0d775a - Browse repository at this point
Copy the full SHA b0d775aView commit details
Commits on Oct 21, 2021
-
Merge branch 'develop' of github.com:matrix-org/synapse into anoa/e2e…
…_as_room_stream_token
Configuration menu - View commit details
-
Copy full SHA for 9abbd08 - Browse repository at this point
Copy the full SHA 9abbd08View commit details
Commits on Oct 26, 2021
-
Add missing return type hints for stream ids
While searching around for all types that were eventually passed into on_new_event, I found a couple methods which didn't specify the type they returned. So this commit adds return type hints for those methods. I didn't do any other arguments as I plan to type-hint those files later anyways.
Configuration menu - View commit details
-
Copy full SHA for ebda0d1 - Browse repository at this point
Copy the full SHA ebda0d1View commit details -
Remove _notify_app_services_ephemeral; convert token in on_new_event …
…instead This is a small effort to reduce the layers of methods we have here. Also, I've opted to continue converting the RoomStreamToken to an int, but only for when tracking stream tokens of EDUs. As stated in the comment, this shouldn't have any gaps as long as we *always* convert to minimum value.
Configuration menu - View commit details
-
Copy full SHA for 61f9a82 - Browse repository at this point
Copy the full SHA 61f9a82View commit details
Commits on Oct 27, 2021
-
Merge branch 'develop' of github.com:matrix-org/synapse into anoa/e2e…
…_as_room_stream_token
Configuration menu - View commit details
-
Copy full SHA for c051fb7 - Browse repository at this point
Copy the full SHA c051fb7View commit details
Commits on Nov 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for c9ede35 - Browse repository at this point
Copy the full SHA c9ede35View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4414e22 - Browse repository at this point
Copy the full SHA 4414e22View commit details
Commits on Nov 2, 2021
-
Apply suggestions from code review
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 8411bdb - Browse repository at this point
Copy the full SHA 8411bdbView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.