Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Deal with mypy errors w/ type-hinted pynacl 1.5.0 #11714

Merged
merged 3 commits into from
Jan 10, 2022
Merged

Deal with mypy errors w/ type-hinted pynacl 1.5.0 #11714

merged 3 commits into from
Jan 10, 2022

Commits on Jan 10, 2022

  1. Deal with mypy errors w/ type-hinted pynacl 1.5.0 

    Fixes #11644.

I really don't like that we're monkey patching pynacl SignedKey
instances with alg and version objects. But I'm too scared to make the
changes necessary right now.

(Ideally I would replace `signedjson.types.SingingKey` with a runtime class which
wraps or inherits from `nacl.signing.SigningKey`.)
    David Robertson committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    a562c8e View commit details
    Browse the repository at this point in the history

  2. Changelog

    David Robertson committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    a2bb73c View commit details
    Browse the repository at this point in the history

  3. Try to explain why there are two signing key types

    David Robertson committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    683cccb View commit details
    Browse the repository at this point in the history