Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix overflows in /messages backfill calculation #13936

Merged
merged 14 commits into from
Sep 30, 2022
Merged

Fix overflows in /messages backfill calculation #13936

merged 14 commits into from
Sep 30, 2022

Commits on Sep 28, 2022

  1. Reproduce bug 

    Test with
```
SYNAPSE_TEST_LOG_LEVEL=DEBUG SYNAPSE_POSTGRES=1 SYNAPSE_POSTGRES_HOST=127.0.0.1 SYNAPSE_POSTGRES_USER=postgres SYNAPSE_POSTGRES_PASSWORD=postgres poetry run trial tests.storage.test_event_federation.EventFederationWorkerStoreTestCase.test_repeated_backfill_failures_are_retried_appropriately
```
having setup a postgres server with
```
docker run --rm -e POSTGRES_PASSWORD=postgres -e POSTGRES_USER=postgres -e POSTGRES_DB=synapse -p 5432:5432 postgres:10-alpine
```
    David Robertson committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    042841e View commit details
    Browse the repository at this point in the history

  2. Compute least_function first

    David Robertson committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    9412bf6 View commit details
    Browse the repository at this point in the history

  3. Substitute least_function with an f-string

    David Robertson committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    83f4e52 View commit details
    Browse the repository at this point in the history

  4. Bugfix: avoid overflow

    David Robertson committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    4a0c461 View commit details
    Browse the repository at this point in the history

  5. Changelog

    David Robertson committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    2a800fc View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2022

  1. Drive-by: prefer assertEqual over assertListEqual

    David Robertson committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    4f6637d View commit details
    Browse the repository at this point in the history

  2. prefer LEAST over least

    David Robertson committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    c392efc View commit details
    Browse the repository at this point in the history

  3. Make the constant hold milliseconds

    David Robertson committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    c713c8e View commit details
    Browse the repository at this point in the history

  4. Update explanatory comment; add assertion

    David Robertson committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    a91d810 View commit details
    Browse the repository at this point in the history

  5. Another comment tweak

    David Robertson committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    6314b16 View commit details
    Browse the repository at this point in the history

  6. Test common backfill path over insertion events

    David Robertson committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    34c3900 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'develop' into dmr/messages/fix-overflow

    David Robertson committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    93f02cd View commit details
    Browse the repository at this point in the history

  8. Tweak test description 

    Co-authored-by: Eric Eastwood <erice@element.io>
    @MadLittleMods
    David Robertson and MadLittleMods committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    20204e5 View commit details
    Browse the repository at this point in the history

  9. Fix the test!!

    David Robertson committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    5830290 View commit details
    Browse the repository at this point in the history