This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Wait for stream change cache position deviceinbox #14286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This appears to have previously been done within the room depth handling and only for local events.
…w IDs This ensures that every time a new device inbox stream ID is generated both stream change caches that utilise it are notified of that position, even if there are no relevant changes at that point. This ensures that the max position of these caches is always updated to match the current token, which then makes it possible to wait for changes to arrive over replication.
Where device inbox message creation is rate limited the next ID call is still executed, this change exits early when the rate limit has removed any messages to persist.
|
Closing for now in favour of fixing the lefover races. |
Fizzadar
deleted the
wait-for-stream-change-cache-position-deviceinbox
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on/builds upon: #14269
Signed off by Nick @ Beeper (@Fizzadar).
Pull Request Checklist
(run the linters)