Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Admin API to list, filter and sort rooms #6720

Merged
merged 23 commits into from
Jan 22, 2020
Merged

Admin API to list, filter and sort rooms #6720

merged 23 commits into from
Jan 22, 2020

Conversation

anoadragon453
Copy link
Member

@anoadragon453 anoadragon453 commented Jan 16, 2020 •
edited
Loading

Fixes #6424

TODO: docs

@anoadragon453 anoadragon453 self-assigned this Jan 16, 2020
@anoadragon453 anoadragon453 requested a review from a team January 17, 2020 16:52
erikjohnston
erikjohnston previously requested changes Jan 20, 2020
View reviewed changes
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, sorry for the number of comments they're mostly just nits or removing debug logging.

synapse/handlers/admin.py Outdated Show resolved Hide resolved
synapse/rest/admin/rooms.py Outdated Show resolved Hide resolved
synapse/rest/admin/rooms.py Outdated Show resolved Hide resolved
synapse/rest/admin/rooms.py Show resolved Hide resolved
synapse/rest/admin/rooms.py Outdated Show resolved Hide resolved
tests/rest/admin/test_admin.py Outdated Show resolved Hide resolved
tests/rest/admin/test_admin.py Outdated Show resolved Hide resolved
tests/rest/admin/test_admin.py Outdated Show resolved Hide resolved
tests/rest/admin/test_admin.py Outdated Show resolved Hide resolved
tests/rest/admin/test_admin.py Outdated Show resolved Hide resolved
@anoadragon453 anoadragon453 mentioned this pull request Jan 20, 2020
Merged
erikjohnston
erikjohnston reviewed Jan 21, 2020
View reviewed changes
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good now, just I'm not sure if we want to add support for paginating backwards?

docs/admin_api/rooms.md Show resolved Hide resolved
synapse/rest/admin/rooms.py Outdated Show resolved Hide resolved
@anoadragon453 anoadragon453 merged commit 90a28fb into develop Jan 22, 2020
@anoadragon453 anoadragon453 deleted the anoa/admin_list_rooms branch January 22, 2020 13:36
@anoadragon453 anoadragon453 mentioned this pull request Jan 22, 2020
Closed
babolivier pushed a commit that referenced this pull request Sep 1, 2021
@anoadragon453
Admin API to list, filter and sort rooms (#6720)
fc43d20 
* commit '90a28fb47':
  Admin API to list, filter and sort rooms (#6720)
@DMRobertson DMRobertson mentioned this pull request Jan 14, 2022
Merged
4 tasks
@anoadragon453 anoadragon453 mentioned this pull request Jan 17, 2022
Open
@matrixbot matrixbot mentioned this pull request Dec 21, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erikjohnston erikjohnston erikjohnston approved these changes

Assignees

@anoadragon453 anoadragon453

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anoadragon453 @erikjohnston