Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Do not return aliases as part of the public room list #6970

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Do not return aliases as part of the public room list #6970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/6970.removal
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
The room list endpoint no longer returns a list of aliases.
9 changes: 0 additions & 9 deletions synapse/handlers/room_list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,15 +216,6 @@ def build_room_entry(room):
direction_is_forward=False,
).to_token()

for room in results:
# populate search result entries with additional fields, namely
# 'aliases'
room_id = room["room_id"]

aliases = yield self.store.get_aliases_for_room(room_id)
if aliases:
room["aliases"] = aliases

response["chunk"] = results

response["total_room_count_estimate"] = yield self.store.count_public_rooms(
Expand Down