Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Move client command handling out of TCP protocol #7185

Merged
merged 21 commits into from
Apr 6, 2020
Merged

Move client command handling out of TCP protocol #7185

merged 21 commits into from
Apr 6, 2020

Commits on Mar 31, 2020

  1. Add replication data handler concept. 

    This stops us having to subclass ReplicationClientHandler and override
methods.
    @erikjohnston
    erikjohnston committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    699ccf3 View commit details
    Browse the repository at this point in the history

  2. Remove connection closed checks. 

    This will get replaced with a Linearizer later.
    @erikjohnston
    erikjohnston committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    5b1e760 View commit details
    Browse the repository at this point in the history

  3. Don't use POSITION to detect "finished connecting". 

    In a Redis world we won't necessarily get one POSITION per stream at the
start of the connection, so we rejig our "streams connecting" logic.
    @erikjohnston
    erikjohnston committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    8f1a878 View commit details
    Browse the repository at this point in the history

  4. Add ReplicationCommandHandler. 

    The intention is to move all command processing logic to there, out of
protocol, client and resource modules. Currently we only pull out client
command processing from protocol and delegate to
ReplicationClientHandler.
    @erikjohnston
    erikjohnston committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    a0063c9 View commit details
    Browse the repository at this point in the history

  5. Merge replication command and client handlers

    @erikjohnston
    erikjohnston committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    7e2593b View commit details
    Browse the repository at this point in the history

  6. Fix test

    @erikjohnston
    erikjohnston committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    90bd170 View commit details
    Browse the repository at this point in the history

  7. Add linearizer to protect stream catchup

    @erikjohnston
    erikjohnston committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    6ac1eca View commit details
    Browse the repository at this point in the history

  8. Newsfile

    @erikjohnston
    erikjohnston committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    5104d16 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2020

  1. Add diagram off how the classes are laid out

    @erikjohnston
    erikjohnston committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    730dbee View commit details
    Browse the repository at this point in the history

  2. Update docstring of ReplicationDataHandler

    @erikjohnston
    erikjohnston committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    23de3af View commit details
    Browse the repository at this point in the history

  3. Remove MYPY=False hack

    @erikjohnston
    erikjohnston committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    0d6e753 View commit details
    Browse the repository at this point in the history

  4. Fixup handler

    @erikjohnston
    erikjohnston committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    e16225a View commit details
    Browse the repository at this point in the history

  5. Fixup protocol.py

    @erikjohnston
    erikjohnston committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    8503564 View commit details
    Browse the repository at this point in the history

  6. Fix up client factory

    @erikjohnston
    erikjohnston committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    cf57d56 View commit details
    Browse the repository at this point in the history

  7. Fixup tests

    @erikjohnston
    erikjohnston committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    dc91879 View commit details
    Browse the repository at this point in the history

  8. Add on_remote_server_up to ReplicationDataHandler

    @erikjohnston
    erikjohnston committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    bf99c8e View commit details
    Browse the repository at this point in the history

  9. Fixup admin handler

    @erikjohnston
    erikjohnston committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    1ebfa39 View commit details
    Browse the repository at this point in the history

  10. Only accept RDATA commands if we've caught up with stream.

    @erikjohnston
    erikjohnston committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    ca9778c View commit details
    Browse the repository at this point in the history

  11. Correctly handle RDATA that comes in while we catch up with a stream

    @erikjohnston
    erikjohnston committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    534bd86 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2020

  1. Fix up comments

    @erikjohnston
    erikjohnston committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    99e4a99 View commit details
    Browse the repository at this point in the history

  2. Revert to previous (racey) handling of POSITION and RDATA, and move i… 

    …nto linearizer
    @erikjohnston
    erikjohnston committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    4873583 View commit details
    Browse the repository at this point in the history