Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix missing null character check on guest_access room state #8373

Merged
merged 2 commits into from
Sep 23, 2020
Merged

Fix missing null character check on guest_access room state #8373

merged 2 commits into from
Sep 23, 2020

Commits on Sep 22, 2020

  1. Fix missing null character check on guest_access room state 

    When updating room_stats_state, we try to check for null bytes slipping
in to the
content for state events. It turns out we had added guest_access as a
field to
room_stats_state without including it in the null byte check.

Lo and behold, a null byte in a m.room.guest_access event then breaks
room_stats_state
updates.

This PR adds the check for guest_access. A further PR will improve this
function so that this hopefully does not happen again in future.
    @anoadragon453
    anoadragon453 committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    4325be1 View commit details
    Browse the repository at this point in the history

  2. Changelog

    @anoadragon453
    anoadragon453 committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    48336ee View commit details
    Browse the repository at this point in the history