Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Mark the shadow_banned column as boolean in synapse_port_db. #8386

Merged
merged 2 commits into from
Sep 24, 2020
Merged

Mark the shadow_banned column as boolean in synapse_port_db. #8386

merged 2 commits into from
Sep 24, 2020

Conversation

clokep
Copy link
Member

@clokep clokep commented Sep 23, 2020

This fixes #8384, but not the underlying issue of why tests didn't fail.

@clokep clokep mentioned this pull request Sep 23, 2020
Closed
@clokep
Copy link
Member Author

clokep commented Sep 23, 2020

I could also target release-v1.20.0 branch if we want. I don't know if this is enough to do a release for.

@clokep clokep requested a review from a team September 23, 2020 15:46
erikjohnston
erikjohnston approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth basing off of release-v1.20.0 and merge without squashing in case we do want a v1.20.1?

@erikjohnston
Copy link
Member

Might be worth adding an entry with a shadow banned entry to the users table in .buildkite/test_db.db so that it gets caught by CI?

@clokep
Copy link
Member Author

clokep commented Sep 23, 2020

Might be worth adding an entry with a shadow banned entry to the users table in .buildkite/test_db.db so that it gets caught by CI?

Did not realize this is where that data is stored. I've done the following:

  • Run the ./scripts-dev/update_database script on .buildkit/test_db.db
  • Manually modified the database to set shadow_banned to 0 for one of the users (@01register-user-20191002_181700:localhost:8800)

Does this sound sane? It's a binary file so...changes can't really be seen. I'm unsure if this file had some special configuration or anything or if running the update_database script on it is OK.

@erikjohnston
Copy link
Member

Sounds sane to me, though I'm not hugely familiar with it. Does this sound sane to you @babolivier ?

@babolivier
Copy link
Contributor

Sounds sane to me, though I'm not hugely familiar with it. Does this sound sane to you @babolivier ?

Yep, sounds good to me!

@clokep clokep merged commit 13099ae into develop Sep 24, 2020
@clokep clokep deleted the clokep/shadow-banned-port-db branch September 24, 2020 12:13
anoadragon453 pushed a commit that referenced this pull request Sep 24, 2020
@clokep @anoadragon453
Mark the shadow_banned column as boolean in synapse_port_db. (#8386)
f3e5c2e
babolivier pushed a commit that referenced this pull request Sep 1, 2021
@anoadragon453
Merge commit '920dd1083' into anoa/dinsic_release_1_21_x
d70f909 
* commit '920dd1083':
  1.20.1
  Mark the shadow_banned column as boolean in synapse_port_db. (#8386)
  Hotfix: disable autoescape by default when rendering Jinja2 templates (#8394)
babolivier pushed a commit that referenced this pull request Sep 1, 2021
@anoadragon453
Merge commit '31acc5c30' into anoa/dinsic_release_1_21_x
5b0b103 
* commit '31acc5c30':
  Escape the error description on the sso_error template. (#8405)
  Fix occasional "Re-starting finished log context" from keyring (#8398)
  Allow existing users to login via OpenID Connect. (#8345)
  Fix schema delta for servers that have not backfilled (#8396)
  Fix MultiWriteIdGenerator's handling of restarts. (#8374)
  s/URLs/variables in changelog
  s/accidentally/incorrectly in changelog
  Update changelog wording
  Add type annotations to SimpleHttpClient (#8372)
  Add new sequences to port DB script (#8387)
  Add EventStreamPosition type (#8388)
  Mark the shadow_banned column as boolean in synapse_port_db. (#8386)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erikjohnston erikjohnston erikjohnston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migration to postgresql is broken on table users, column shadow_banned
3 participants
@clokep @erikjohnston @babolivier