-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-1371 - Add readtoken when in readonly mode #1382
Conversation
@jespino, @harshilsharma63 - I know you guys have been doing some work on routes, so I wanted to make sure you see what is changing here. |
@sbishel worked fine with 0.9 release branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- able to change views as a non-validated user without error
- card view displayed as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cherry pick is scheduled. |
Error trying doing the automated Cherry picking. Please do this manually
|
(cherry picked from commit 35bb3e9)
Summary
This PR fixes two issues.
This appears to work in Personal Server, however, because the token is not included in the query string, a refresh in Personal Server results in the same error.
Add the
?r=readtoken
parameter to the url path when either displaying a different view or a card view.I think this is due to the recent route changes.
Add the
/cardId?
parameter to the "shared" routes.Ticket Link
Fixes #1371