Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-1371 - Add readtoken when in readonly mode #1382

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

sbishel
Copy link
Collaborator

@sbishel sbishel commented Sep 30, 2021

Summary

This PR fixes two issues.

  1. When we change views on shared boards, non validated users receive an Access Denied error.
    This appears to work in Personal Server, however, because the token is not included in the query string, a refresh in Personal Server results in the same error.

Add the ?r=readtoken parameter to the url path when either displaying a different view or a card view.

  1. While testing, the card view was not being displayed in read-only view.
    I think this is due to the recent route changes.

Add the /cardId? parameter to the "shared" routes.

Ticket Link

Fixes #1371

@sbishel sbishel requested a review from a team as a code owner September 30, 2021 20:29
@sbishel sbishel added 2: Dev Review Requires review by a core committer 2: QA Review Requires review by a QA tester labels Sep 30, 2021
@sbishel sbishel requested review from ogi-m and removed request for a team September 30, 2021 20:29
@sbishel sbishel added this to the v0.9 milestone Sep 30, 2021
@sbishel sbishel added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Sep 30, 2021
@sbishel
Copy link
Collaborator Author

sbishel commented Sep 30, 2021

@jespino, @harshilsharma63 - I know you guys have been doing some work on routes, so I wanted to make sure you see what is changing here.

@harshilsharma63
Copy link
Member

@sbishel worked fine with 0.9 release branch.

Copy link
Contributor

@ogi-m ogi-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • able to change views as a non-validated user without error
  • card view displayed as expected

@ogi-m ogi-m removed the 2: QA Review Requires review by a QA tester label Oct 1, 2021
Copy link
Contributor

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jespino jespino added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Oct 1, 2021
@sbishel sbishel merged commit 35bb3e9 into main Oct 1, 2021
@mattermod
Copy link
Contributor

Cherry pick is scheduled.

@mattermod
Copy link
Contributor

Error trying doing the automated Cherry picking. Please do this manually

fatal: No such remote 'upstream'

+++ Returning you to the main branch and cleaning up.

@sbishel sbishel deleted the gh-1371-shared-board-access branch October 1, 2021 17:29
sbishel added a commit that referenced this pull request Oct 1, 2021
@sbishel sbishel added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Access denied when changing views in a shared board
5 participants