Fix #1397. Add show empty toggle to Dashboard #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenilim
requested review from
wiggin77 and
sbishel
and removed request for
a team
|
@chenilim I think you need to update the test snapshot. |
wiggin77
requested changes
Oct 1, 2021
|
Yup, thanks. Looking into it. My environment seems to be borked, as jest is failing on something unrelated ( |
|
Ok, turns out my node version was outdated. Updated the snapshot, and should be final now. Thanks. |
sbishel
requested changes
Oct 1, 2021
webapp/src/userSettings.ts
Outdated
| static set dashboardShowEmpty(newValue: boolean) { | ||
| localStorage.setItem('dashboardShowEmpty', JSON.stringify(newValue)) | ||
| } | ||
|
|
There was a problem hiding this comment.
Can we add the new item name to the UserSettingKey enum above? Also call the local methods for consistency.
There was a problem hiding this comment.
Thanks, done. I originally made the changes on the release-0.9.0 branch, and missed this enum.
sbishel
approved these changes
Oct 2, 2021
chenilim
added
the
CherryPick/Approved
chenilim
added a commit
that referenced
this pull request
Oct 4, 2021
chenilim
added
the
CherryPick/Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a "Show empty" toggle to the Dashboard to show / hide workspaces with no boards. This setting is persisted in localStorage.
Ticket Link
#1397