Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update snapshots, remove tests for release-0.9.0 #1454

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

sbishel
Copy link
Collaborator

@sbishel sbishel commented Oct 5, 2021

Summary

Fixes up some snapshots that were different due to a couple unit test PRs not being CP'ed to release-0.9.0.
#1063
#1114

Attempted to CP that PR, but resulted in more fixes and a larger PR for release-0.9.0.

Decision was made to fix up snapshots and removing tests that depended on those PR changes.

Ticket Link

Fixes #1442

@sbishel sbishel requested a review from a team as a code owner October 5, 2021 17:14
@sbishel sbishel requested review from wiggin77 and hahmadia and removed request for a team, wiggin77 and hahmadia October 5, 2021 17:14
@sbishel sbishel added the 2: Dev Review Requires review by a core committer label Oct 5, 2021
@sbishel sbishel added this to the v0.9 milestone Oct 5, 2021
Copy link
Contributor

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sbishel sbishel merged commit 1f915e5 into release-0.9.0 Oct 5, 2021
@sbishel sbishel deleted the fix-0.9-tests branch October 5, 2021 18:24
@sbishel sbishel added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants