Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a check to ensure that the URL view belongs to the board or redirects #1468

Merged
merged 3 commits into from
Oct 6, 2021
Merged

Adds a check to ensure that the URL view belongs to the board or redirects #1468

merged 3 commits into from
Oct 6, 2021

Conversation

mgdelacroix
Copy link
Contributor

Summary

This PR adds a check when loading the board page to ensure that the view on the URL belongs to the board of it. This way, if you're navigating Boards and go from board A view A to board B (directly to the board instead of the view), instead of loading board B and view A (and generating a bad shared board URL as a result of this) it will catch the inconsistency and redirect to view B.

Fixes #1392

@mgdelacroix mgdelacroix added 2: Dev Review Requires review by a core committer 2: QA Review Requires review by a QA tester labels Oct 6, 2021
@mgdelacroix mgdelacroix added this to the v0.9 milestone Oct 6, 2021
@mgdelacroix mgdelacroix requested a review from a team as a code owner October 6, 2021 15:30
@mgdelacroix mgdelacroix removed the request for review from a team October 6, 2021 15:30
@mgdelacroix mgdelacroix added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Oct 6, 2021
@mgdelacroix mgdelacroix mentioned this pull request Oct 6, 2021
Merged
ogi-m
ogi-m approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@ogi-m ogi-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ogi-m ogi-m removed the 2: QA Review Requires review by a QA tester label Oct 6, 2021
@mgdelacroix mgdelacroix merged commit 85ccc05 into main Oct 6, 2021
@mgdelacroix mgdelacroix deleted the ensure-view-is-from-board branch October 6, 2021 16:57
@mattermod
Copy link
Contributor

Cherry pick is scheduled.

@mattermod
Copy link
Contributor

Error trying doing the automated Cherry picking. Please do this manually

fatal: No such remote 'upstream'

+++ Returning you to the main branch and cleaning up.

@mgdelacroix mgdelacroix restored the ensure-view-is-from-board branch October 6, 2021 16:58
@mgdelacroix mgdelacroix deleted the ensure-view-is-from-board branch October 6, 2021 16:58
mgdelacroix added a commit that referenced this pull request Oct 6, 2021
@mgdelacroix
Adds a check to ensure that the URL view belongs to the board or redi…
0fcae0e 
…rects (#1468)

* Adds a check to ensure that the URL view belongs to the board or redirects

* Fix linter
@mgdelacroix mgdelacroix added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbishel sbishel sbishel approved these changes

@ogi-m ogi-m ogi-m approved these changes

@harshilsharma63 harshilsharma63 Awaiting requested review from harshilsharma63

Assignees
No one assigned
Labels
2: Dev Review Requires review by a core committer CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone
Projects
None yet
Milestone
v0.9
Development

Successfully merging this pull request may close these issues.

Bug: Sharing Board Link without a view selected creates invalid url
4 participants
@mgdelacroix @mattermod @sbishel @ogi-m