Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add non-reliable websockets support #1497

Merged
merged 5 commits into from
Oct 21, 2021
Merged

Add non-reliable websockets support #1497

merged 5 commits into from
Oct 21, 2021

Conversation

mgdelacroix
Copy link
Contributor

Summary

This PR makes use of the firstConnectCallback to mark the Mattermost websocket as connected instead of polling its state, allowing for instances with reliable websockets unset to use Focalboard normally.

@mgdelacroix mgdelacroix added 2: Dev Review Requires review by a core committer 2: QA Review Requires review by a QA tester CherryPick/Candidate A candidate for a quality or patch release, but not yet approved labels Oct 8, 2021
@mgdelacroix mgdelacroix requested a review from a team as a code owner October 8, 2021 15:50
@mgdelacroix mgdelacroix removed the request for review from a team October 8, 2021 15:57
@mgdelacroix
Copy link
Contributor Author

@ogi-m this PR should be tested on instances with ServiceSettings.EnableReliableWebSockets set to true and false to ensure that the changes work for both

jespino
jespino approved these changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbishel
Copy link
Collaborator

sbishel commented Oct 15, 2021

/update-branch

@ogi-m ogi-m removed the 2: QA Review Requires review by a QA tester label Oct 20, 2021
@sbishel
Copy link
Collaborator

sbishel commented Oct 20, 2021

/update-branch

@mgdelacroix mgdelacroix added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Oct 21, 2021
@mgdelacroix mgdelacroix merged commit afc37ca into main Oct 21, 2021
@mgdelacroix mgdelacroix deleted the add-non-reliable-ws-support branch October 21, 2021 13:44
@chenilim chenilim added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Oct 21, 2021
@chenilim
Copy link
Contributor

Please cherry-pick to release-0.9.0, for v0.9.4, if you haven't already. Thanks.

mgdelacroix added a commit that referenced this pull request Oct 22, 2021
@mgdelacroix @mattermod @sbishel
Add non-reliable websockets support (#1497)
0b9446e 
* Add non-reliable websockets support

* Remove unused properties

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
Co-authored-by: Scott Bishel <scott.bishel@mattermost.com>
@mgdelacroix mgdelacroix added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone CherryPick/Candidate A candidate for a quality or patch release, but not yet approved labels Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jespino jespino jespino approved these changes

@sbishel sbishel sbishel approved these changes

@ogi-m ogi-m ogi-m approved these changes

Assignees
No one assigned
Labels
3: Reviews Complete All reviewers have approved the pull request CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mgdelacroix @sbishel @chenilim @jespino @ogi-m @mattermod