Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no css example to readme #111

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Conversation

GeeCastro
Copy link
Contributor

Adresses #100 in the readme

README.rst Show resolved Hide resolved
@AlexVonB AlexVonB merged commit a2f8267 into matthewwithanm:develop Mar 11, 2024
1 check passed
@chrispy-snps
Copy link
Collaborator

@AlexVonB, @GeeCastro - now that <script> and <style> are ignored by the base code per #112, I think we should remove this workaround example as it would no longer have any effect. Are you agreeable to this?

@GeeCastro
Copy link
Contributor Author

Yep 👍

@chrispy-snps
Copy link
Collaborator

@GeeCastro - if it weren't for the unfortunately-timed (?) fix, this would have been a great example of the extension mechanism! Thank you for contributing.

@GeeCastro
Copy link
Contributor Author

I think the doc could be clearer if it said how easy the def concert_<tag>(…) works. Let me open another small pr

@GeeCastro
Copy link
Contributor Author

#116 something like this feel free to rephrase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants