Make role_bounds optional to require just login #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Github is complaining about a merge conflict. |
|
@maxcountryman will fix tomorrow. Do you think this is correct btw? I hope I didn't miss anything. |
|
@epilys thanks. As far as correctness: I think so, it's helpful to have the test cases, so thank you for adding those. |
Because we can't know if RoleBounds is a full range or not, we cannot
know if a None role means we must authenticate the user. So make
RoleBounds optional.
Closes #66
|
@maxcountryman ping |
|
Thanks, @epilys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #66