Fix user extension implementation #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current extension is of type Option<User>. This is less ergonomic for handlers that already use RequireAuthorizationLayer.
axum-login/src/auth.rs
Outdated
Comment on lines
131
to
133
| request | ||
| .extensions_mut() | ||
| .insert(auth_cx.current_user.clone()); |
There was a problem hiding this comment.
Is the idea in keeping this to preserve backwards compatibility?
I'm a little concerned it's confusing to have Option<User> and User as extensions.
There was a problem hiding this comment.
Yes, lines 131-133 are for backwards compatibility while lines 134-136 implements the extension as described in the doc examples.
I am open to dropping lines 131-133 if you're not concerned with backwards compatibility. This change should be relatively safe as the Option<User> extension wasn't documented.
There was a problem hiding this comment.
I think it's safe to drop given we're pre-1.0.
There was a problem hiding this comment.
Sounds good, I have updated the pull request.
The documented user extension type is of type User but the implemented extension is of type Option<User>. This is less ergonomic for handlers that already use RequireAuthorizationLayer.
bngo92
changed the title
|
Thank you for putting this together! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current extension is of type Option.
This is less ergonomic for handlers that already use RequireAuthorizationLayer.