Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Catena_Serial abstaction doesn't work with STM32 UsbSerial ports #319

Closed
terrillmoore opened this issue Sep 13, 2021 · 0 comments
Closed

The Catena_Serial abstaction doesn't work with STM32 UsbSerial ports #319

terrillmoore opened this issue Sep 13, 2021 · 0 comments
Assignees
@terrillmoore
Labels
bug

Comments

@terrillmoore
Copy link
Member

The abstraction (necessarily) exports cSerial::begin(unsigned long baudrate, uint16_t config). But STM32 UsbSerial doesn't have a two-parameter begin(). This results in a compile error when trying to create a cSerial<UsbSerial>.

Need to use template metaprogramming to detect the lack of a method and use UsbSerial::begin(baudrate) instead.
@terrillmoore terrillmoore self-assigned this Sep 13, 2021
terrillmoore added a commit that referenced this issue Sep 13, 2021
@terrillmoore
Merge pull request #320 from mcci-catena/issue319
aa6d14f 
Fix #319: cSerial<> didn't work for STM32 USB Serial.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terrillmoore terrillmoore

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@terrillmoore