Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration offset is ignored #105

Closed
paul53 opened this issue Jul 21, 2023 · 2 comments
Closed

Configuration offset is ignored #105

paul53 opened this issue Jul 21, 2023 · 2 comments
Labels
bug Something isn't working fixed
Milestone
Release 1.0.x

Comments

@paul53
Copy link

paul53 commented Jul 21, 2023

Der Offset aus der Konfiguration wird nicht in para.off übernommen, sondern ein vorhandener Wert wird bei Instanz-Start mit 0 überschrieben.
@mcm1957 mcm1957 self-assigned this Jul 21, 2023
@mcm1957 mcm1957 added the bug Something isn't working label Aug 9, 2023
@mcm1957
Copy link
Contributor

mcm1957 commented Feb 27, 2024

Controller scheint nach offs zu suchen während der restliche Code off verwendet.
... nach zu checken und ggF zu fixen ...

mcm1957 added a commit that referenced this issue Mar 11, 2024
@mcm1957
fix param offset [#105]
658889b
@mcm1957 mcm1957 added the fixed label Mar 11, 2024
@mcm1957 mcm1957 removed their assignment Mar 11, 2024
mcm1957 added a commit that referenced this issue Mar 11, 2024
@mcm1957
chore: release v1.0.0-alpha.0
beb56c5 
-   (mcm1957) BREAKING: Adapter requires node.js 18 or newer now
-   (mcm1957) BREAKING: Adapter requires js-controller 5.x.x and admin 6.x.x or newer now
-   (mcm1957) Parameter offset was non functional. This has been fixed. [#105]
-   (mcm1957) Incorrect error message whenever no controllers have been defied has been removed. [#68]
-   (mcm1957) State roles have been reviewed and adapted. [#88]
-   (mcm1957) Dependencies have been updated.
mcm1957 added a commit that referenced this issue Mar 11, 2024
@mcm1957
chore: release v1.0.0
1ac7012 
-   (mcm1957) BREAKING: Adapter requires node.js 18 or newer now
-   (mcm1957) BREAKING: Adapter requires js-controller 5.x.x and admin 6.x.x or newer now
-   (mcm1957) Parameter offset was non functional. This has been fixed. [#105]
-   (mcm1957) Incorrect error message whenever no controllers have been defied has been removed. [#68]
-   (mcm1957) State roles have been reviewed and adapted. [#88]
-   (mcm1957) Dependencies have been updated.
@mcm1957
Copy link
Contributor

mcm1957 commented Mar 11, 2024

fixed with 1.0.0

@mcm1957 mcm1957 added this to the Release 1.0.x milestone Mar 22, 2024
@mcm1957 mcm1957 closed this as completed Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working fixed
Projects
None yet
Milestone
Release 1.0.x
Development

No branches or pull requests
2 participants
@paul53 @mcm1957