Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge devnet-v3 with latest master #43

Merged
merged 194 commits into from
Nov 4, 2022
Merged

merge devnet-v3 with latest master #43

merged 194 commits into from
Nov 4, 2022

Commits on Aug 18, 2022

  1. cmd. core: save preimages on genesis creation (ethereum#25538)

    force preimage dump for genesis
    gballet committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    23ac8df View commit details
    Browse the repository at this point in the history
  2. rlp/rlpgen: fix error handling when target type not found (ethereum#2…

    …5547)
    
    typ will be nil when lookupStructType returns an error. cfg.Type should be used instead.
    jtraglia committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    cce7f08 View commit details
    Browse the repository at this point in the history
  3. trie: improve node rlp decoding performance (ethereum#25357)

    This avoids copying the input []byte while decoding trie nodes. In most
    cases, particularly when the input slice is provided by the underlying
    database, this optimization is safe to use.
    
    For cases where the origin of the input slice is unclear, the copying version
    is retained. The new code performs better even when the input must be
    copied, because it is now only copied once in decodeNode.
    rjl493456442 committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    a1b8892 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2022

  1. all: fix some typos (ethereum#25551)

    * Fix some typos
    
    * Fix some mistakes
    
    * Revert 4byte.json
    
    * Fix an incorrect fix
    
    * Change files to fails
    jtraglia committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    2c5648d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fa1305f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    32e8490 View commit details
    Browse the repository at this point in the history
  4. eth, les: unlock downloader peerSet if there's an error (ethereum#25546)

    Unlock peerSet if there's an error in the downloader
    jtraglia committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    656dc8c View commit details
    Browse the repository at this point in the history
  5. cmd/geth: parse uint64 value with ParseUint instead of Atoi (ethereum…

    …#25545)
    
    Parse uint64 value with ParseUint instead of Atoi
    jtraglia committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    9762ddf View commit details
    Browse the repository at this point in the history
  6. consensus/beacon: check ttd reached on pos blocks (ethereum#25552)

    * consensus/beacon: check ttd reached on pos blocks
    
    * consensus/beacon: check ttd reached on pos blocks
    
    * consensus/beacon: check ttd reached on pos blocks
    MariusVanDerWijden committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    77308cd View commit details
    Browse the repository at this point in the history
  7. eth/filters: add global block logs cache (ethereum#25459)

    This adds a cache for block logs which is shared by all filters. The cache
    size of is configurable using the `--cache.blocklogs` flag.
    
    Co-authored-by: Felix Lange <fjl@twurst.com>
    s1na and fjl committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    36874b6 View commit details
    Browse the repository at this point in the history
  8. accounts/abi: fix set function (ethereum#25477)

    * accounts/abi: fix set function
    
    * don't break things
    
    * update test
    zhiqiangxu committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    0865880 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    ac7ad81 View commit details
    Browse the repository at this point in the history
  10. eth/fetcher: don't spend too much time on transaction inclusion (ethe…

    …reum#25524)
    
    * eth/fetcher: introduce some lag in tx fetching
    
    * eth/fetcher: change conditions a bit
    
    * eth/fetcher: use per-batch quota check
    
    * eth/fetcher: fix some comments
    
    * eth/fetcher: address review concerns
    
    * eth/fetcher: fix panic + add warn log
    
    * eth/fetcher: fix log
    
    * eth/fetcher: fix log
    
    * cmd/devp2p/internal/ethtest: fix ignorign tx announcements from prev. tests
    
    * cmd/devp2p/internal/ethtest: fix TestLargeTxRequest
    
    This increases the number of tx relay messages the test waits for. Since
    go-ethereum now processes incoming txs in smaller batches, the
    announcement messages it sends are also smaller.
    
    Co-authored-by: Felix Lange <fjl@twurst.com>
    holiman and fjl committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    0ce494b View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2022

  1. Revert "eth/fetcher: don't spend too much time on transaction inclusi…

    …on" (ethereum#25567)
    
    Revert "eth/fetcher: don't spend too much time on transaction inclusion (ethereum#25524)"
    
    This reverts commit 0ce494b.
    karalabe committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    02418c2 View commit details
    Browse the repository at this point in the history
  2. eth/catalyst: warn less frequently if no beacon client is available (e…

    …thereum#25569)
    
    * eth/catalyst: warn less frequently if no beacon client is available
    
    * eth/catalyst: tweak warning frequency a bit
    
    * eth/catalyst: some more tweaks
    
    * Update api.go
    
    Co-authored-by: Felix Lange <fjl@twurst.com>
    karalabe and fjl committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    395f3d4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2de49b0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6d711f0 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. core, eth/downloader: handle spurious junk bodies from racey rollbacks (

    ethereum#25578)
    
    * eth/downloader: handle junkbodies/receipts in the beacon sync
    
    * core: check for header presence when checking for blocks
    karalabe committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    81bd998 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5758d1f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    45a660a View commit details
    Browse the repository at this point in the history
  4. Merge pull request ethereum#25581 from karalabe/triedb-fix-flush-order

    core/state, trie: fix trie flush order for proper pruning
    karalabe committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    9ed10b9 View commit details
    Browse the repository at this point in the history
  5. Merge pull request ethereum#25582 from holiman/err_handling

    consensus/beacon: don't ignore errors
    karalabe committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    4c114af View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. Configuration menu
    Copy the full SHA
    d901d85 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    57896d6 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. Configuration menu
    Copy the full SHA
    6c40aed View commit details
    Browse the repository at this point in the history
  2. internal/ethapi: rename debug getters to match spec (ethereum#25176)

    Some small fixes to get the existing debug methods to conform to the spec. Mainly dropping the encoding information from the method name as it should be deduced from the debug context and allowing the method to be invoked by either block number or block hash. It also adds the method debug_getTransaction which returns the raw tx bytes by tx hash. This is pretty much equivalent to the eth_getRawTransactionByHash method.
    lightclient committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    70e1e65 View commit details
    Browse the repository at this point in the history
  3. accounts/abi/bind: add const for tx fee elasticity multiplier (ethere…

    …um#25504)
    
    
    Co-authored-by: Felix Lange <fjl@twurst.com>
    Co-authored-by: rjl493456442 <garyrong0905@gmail.com>
    3 people committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    f03c37b View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2022

  1. all: remove duplicate word in comments (ethereum#25618)

    Signed-off-by: Abirdcfly <fp544037857@gmail.com>
    
    Signed-off-by: Abirdcfly <fp544037857@gmail.com>
    Abirdcfly committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    c394c30 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. Configuration menu
    Copy the full SHA
    6e6b508 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6d882a5 View commit details
    Browse the repository at this point in the history
  3. docs: specify execution client (ethereum#25566)

    Co-authored-by: Felix Lange <fjl@twurst.com>
    sandakersmann and fjl committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    44b36a0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8df8eb4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7813b67 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2b6df28 View commit details
    Browse the repository at this point in the history
  7. all: move genesis initialization to blockchain (ethereum#25523)

    * all: move genesis initialization to blockchain
    
    * core: add one more check
    
    * core: fix tests
    rjl493456442 committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    d10c280 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2022

  1. eth/catalyst: adjust eta for themerge (ethereum#25601)

    * eth/catalyst: adjust eta for themerge
    
    * squash
    
    * squash
    
    * eth/catalyst: address review concerns
    holiman committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    362256e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    279afd7 View commit details
    Browse the repository at this point in the history
  3. graphql: return correct logs for tx (ethereum#25612)

    * graphql: fix tx logs
    
    * minor
    
    * Use optimized search for selecting tx logs
    s1na committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    8cfcb41 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3d68bb0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    dafa40e View commit details
    Browse the repository at this point in the history
  6. trie: cleanup stateTrie (ethereum#25640)

    It's a trivial PR to hide the error log when the trie node is not found in the database. The idea for this change is for all TryXXX functions, the error is already returned and we don't need to fire a log explicitly.
    
    Recently there are a few tickets ethereum#25613 ethereum#25589 reporting that the trie nodes are missing because of debug.SetHead. The root cause is after resetting, the chain rewinds to a historical point and re-imports the blocks on top.
    
    Since the node is already synced and started to accept transactions previously, these transactions are still kept in the txpool and verified by txpool with a live state. This live state is constructed based on the live trie database, which is changed fast by node referencing and de-referencing.
    
    Unfortunately, when we construct a live state(like the state in txpool), we don't reference the state we have. The blockchain will garbage collect the intermediate version nodes in another thread which leads the broken live state.
    
    The best solution for this is to forcibly obtain a reference for all live states we create and call release function once it's used up. But it might end up with more junks persisted into disk. Will try to find an elegant solution later in the following PR.
    rjl493456442 committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    3f79afb View commit details
    Browse the repository at this point in the history
  7. eth/catalyst: prevent division by zero (ethereum#25654)

    eth/catalyst: prevent diff by zero
    MariusVanDerWijden committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    95a2c22 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. Configuration menu
    Copy the full SHA
    d79bd2f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d46184c View commit details
    Browse the repository at this point in the history
  3. Merge pull request ethereum#25651 from holiman/fix_snapqueue

    eth/protocols/snap: fix problems due to idle-but-busy peers
    karalabe committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    511bf8f View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2022

  1. mobile: register filter APIs (ethereum#25642)

    This fixes a regression introduced in PR ethereum#25459.
    jakub-freebit committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    d2027ac View commit details
    Browse the repository at this point in the history
  2. README.md: improve grammar (ethereum#25646)

    Co-authored-by: Felix Lange <fjl@twurst.com>
    xternet and fjl committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    198fa95 View commit details
    Browse the repository at this point in the history
  3. eth/tracers/js: fill in log.refund field (ethereum#25661)

    For some reason, an accessor method for this field exists in JS, but
    the value was never actually assigned.
    s1na committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    d6a12bc View commit details
    Browse the repository at this point in the history
  4. eth/fetcher: throttle peers which deliver many invalid transactions (e…

    …thereum#25573)
    
    Co-authored-by: Felix Lange <fjl@twurst.com>
    holiman and fjl committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    7f2890a View commit details
    Browse the repository at this point in the history
  5. node, rpc: add JWT auth support in client (ethereum#24911)

    This adds a generic mechanism for 'dial options' in the RPC client,
    and also implements a specific dial option for the JWT authentication
    mechanism used by the engine API. Some real tests for the server-side
    authentication handling are also added.
    
    Co-authored-by: Joshua Gutow <jgutow@optimism.io>
    Co-authored-by: Felix Lange <fjl@twurst.com>
    3 people committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    90711ef View commit details
    Browse the repository at this point in the history
  6. rpc: check that "version" is "2.0" in request objects (ethereum#25570)

    The JSON-RPC spec requires the "version" field to be exactly "2.0",
    so we should verify that. This change is not backwards-compatible with
    sloppy client implementations, but I decided to go ahead with it anyway
    because the failure will be caught via the returned error.
    dbadoy committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    38e002f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    0d68b6b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4b9c307 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2022

  1. eth/tracers/js: improve integer types in log object (ethereum#25668)

    All fields related to gas must be represented as uint64. Depth is
    internally tracked as int, so it makes sense to also store it as int.
    fjl committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    7318858 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Configuration menu
    Copy the full SHA
    a9ec2ab View commit details
    Browse the repository at this point in the history
  2. Merge pull request ethereum#25694 from karalabe/concurrent-heal-check

    trie: check childrens' existence concurrently for snap heal
    karalabe committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    d408cb6 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. Configuration menu
    Copy the full SHA
    5ddedd2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a32a02f View commit details
    Browse the repository at this point in the history
  3. core/vm: rename RANDOM to PREVRANDAO (ethereum#25691)

    See: https://github.com/ethereum/EIPs/blob/master/EIPS/eip-4399.md
    
    >  This EIP supplants the semantics of the return value of existing DIFFICULTY (0x44) opcode and renames the opcode to PREVRANDAO (0x44).
    MariusVanDerWijden committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    d30e39b View commit details
    Browse the repository at this point in the history
  4. all: cleanup tests (ethereum#25641)

    Follow-up to PR ethereum#25523 to cleanup all relevant tests.
    rjl493456442 committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    dea1fb3 View commit details
    Browse the repository at this point in the history
  5. eth, les: rework chain tracer (ethereum#25143)

    This PR simplifies the logic of chain tracer and also adds the unit tests.
    
    The most important change has been made in this PR is the state management. Whenever a tracing state is acquired there is a corresponding release function be returned as well. It must be called once the state is used up, otherwise resource leaking can happen.
    
    And also the logic of state management has been simplified a lot. Specifically, the state provider(eth backend, les backend) should ensure the state is available and referenced. State customers can use the state according to their own needs, or build other states based on the given state. But once the release function is called, there is no guarantee of the availability of the state.
    
    
    Co-authored-by: Sina Mahmoodi <1591639+s1na@users.noreply.github.com>
    Co-authored-by: Péter Szilágyi <peterke@gmail.com>
    3 people committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    b1f6dcc View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Configuration menu
    Copy the full SHA
    6a575ed View commit details
    Browse the repository at this point in the history
  2. trie: update comments + err check for preimages (ethereum#25672)

    This PR includes minor updates to comments in trie/committer that reference insertion to the db, and adds an err != nil check for the return value of preimages.commit.
    darioush committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    8363f79 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2022

  1. eth/protocols/snap: throttle trie heal requests when peers DoS us (et…

    …hereum#25666)
    
    * eth/protocols/snap: throttle trie heal requests when peers DoS us
    
    * eth/protocols/snap: lower heal throttle log to debug
    
    Co-authored-by: Martin Holst Swende <martin@swende.se>
    
    * eth/protocols/snap: fix comment
    
    Co-authored-by: Martin Holst Swende <martin@swende.se>
    karalabe and holiman committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    de8d5fa View commit details
    Browse the repository at this point in the history
  2. p2p/msgrate: be more lenient when calculating 'mean' (ethereum#25653)

    The p2p msgrate tracker is a thing which tries to estimate some mean round-trip times. However, it did so in a very curious way: if a node had 200 peers, it would sort their 200 respective rtt estimates, and then it would pick item number 2 as the mean. So effectively taking third fastest and calling it mean. This probably works "ok" when the number of peers are low (there are other factors too, such as ttlScaling which takes some of the edge off this) -- however when the number of peers is high, it becomes very skewed.
    
    This PR instead bases the 'mean' on the square root of the length of the list. Still pretty harsh, but a bit more lenient.
    holiman committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    06151eb View commit details
    Browse the repository at this point in the history
  3. rpc: improve error codes for internal server errors (ethereum#25678)

    This changes the error code returned by the RPC server in certain situations:
    
    - handler panic: code -32603
    - result marshaling error: code -32603
    - attempt to subscribe via HTTP: code -32001
    
    In all of the above cases, the server previously returned the default error
    code -32000.
    
    Co-authored-by: Nicholas Zhao <nicholas.zhao@gmail.com>
    Co-authored-by: Felix Lange <fjl@twurst.com>
    3 people committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    610cf02 View commit details
    Browse the repository at this point in the history
  4. core: place a cap on reorglogs (ethereum#25711)

    This PR makes the event-sending for deleted and new logs happen in batches, to prevent OOM situation due to large reorgs. 
    
    Co-authored-by: Felix Lange <fjl@twurst.com>
    holiman and fjl committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    389021a View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2022

  1. build: upgrade to go 1.19 (ethereum#25726)

    This changes the CI / release builds to use the latest Go version. It also
    upgrades golangci-lint to a newer version compatible with Go 1.19.
    
    In Go 1.19, godoc has gained official support for links and lists. The
    syntax for code blocks in doc comments has changed and now requires a
    leading tab character. gofmt adapts comments to the new syntax
    automatically, so there are a lot of comment re-formatting changes in this
    PR. We need to apply the new format in order to pass the CI lint stage with
    Go 1.19.
    
    With the linter upgrade, I have decided to disable 'gosec' - it produces
    too many false-positive warnings. The 'deadcode' and 'varcheck' linters
    have also been removed because golangci-lint warns about them being
    unmaintained. 'unused' provides similar coverage and we already have it
    enabled, so we don't lose much with this change.
    fjl committed Sep 10, 2022
    Configuration menu
    Copy the full SHA
    b628d72 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2022

  1. Configuration menu
    Copy the full SHA
    0c1888a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3a4cef5 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. Configuration menu
    Copy the full SHA
    9a3bd11 View commit details
    Browse the repository at this point in the history
  2. graphql: fixes missing tx logs (ethereum#25745)

    * graphql: fix tx logs
    
    * graphql: refactor test service setup
    
    * graphql: add test for tx logs
    s1na committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    818ff32 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2022

  1. cmd/geth: add a verkle subcommand (ethereum#25718)

    * cmd/geth: add a verkle subcommand
    
    * fix copyright year
    
    * remove unused command parameters
    
    * check that the output file was successfully written to
    
    Co-authored-by: Martin Holst Swende <martin@swende.se>
    
    * cmd/geth: goimports fix
    
    Co-authored-by: Martin Holst Swende <martin@swende.se>
    gballet and holiman committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    9d71716 View commit details
    Browse the repository at this point in the history
  2. node: fix HTTP server always force closing (ethereum#25755)

    Co-authored-by: Felix Lange <fjl@twurst.com>
    ngotchac and fjl committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    25b35c9 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2022

  1. Configuration menu
    Copy the full SHA
    0ee8b27 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3db4a13 View commit details
    Browse the repository at this point in the history
  3. les/catalyst/api: add support for ExchangeTransitionConfigurationV1 (e…

    …thereum#25752)
    
    This method is missing in light client mode and breaks consensus clients
    that require a valid response.
    pinkiebell committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    1d2f5cf View commit details
    Browse the repository at this point in the history
  4. params: set TerminalTotalDifficultyPassed to true (ethereum#25769)

    * params: set TerminalTotalDifficultyPassed to true
    
    * Update params/config.go
    
    Co-authored-by: Martin Holst Swende <martin@swende.se>
    MariusVanDerWijden and holiman committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    a89b7ad View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    57a65f0 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2022

  1. Configuration menu
    Copy the full SHA
    83989a1 View commit details
    Browse the repository at this point in the history
  2. crypto/bls12381: docfix of g1 Affine (ethereum#25729)

    bls12381: docfix of g1 Affine.
    georgercarder committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    d213cb0 View commit details
    Browse the repository at this point in the history
  3. internal/ethapi: return error when requesting invalid trie key (ether…

    …eum#25762)
    
    This change makes eth_getProof and eth_getStorageAt return an error when
    the argument contains invalid hex in storage keys.
    
    Co-authored-by: Felix Lange <fjl@twurst.com>
    lightclient and fjl committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    8ade5e6 View commit details
    Browse the repository at this point in the history
  4. core: don't cache zero nonce in txNoncer (ethereum#25603)

    This changes the nonce cache used by TxPool to not store cached
    nonces for non-existing accounts.
    dbadoy committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    ada603f View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2022

  1. core: more compact bad block report (ethereum#25714)

    This shortens the chain config summary in bad block reports,
    and adds go-ethereum version information as well.
    
    Co-authored-by: Felix Lange <fjl@twurst.com>
    lightclient and fjl committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    8e52015 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2022

  1. core: move build version reading to its own package (ethereum#25806)

    This fixes the build with Go 1.17, which does not have BuildInfo.Settings yet.
    fjl committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    468d184 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2022

  1. Configuration menu
    Copy the full SHA
    d728ba9 View commit details
    Browse the repository at this point in the history
  2. Merge pull request ethereum#25831 from karalabe/fix-challenge-stop-hang

    eth: fix a rare datarace on CHT challenge reply / shutdown
    karalabe committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    18a001f View commit details
    Browse the repository at this point in the history
  3. core/vm: return copy of input slice in identity precompile, avoid ret…

    …urndata copy (ethereum#25183)
    
    * core/vm: return copy of input slice in identity precompile.  don't deep copy return data slice upon call completion
    
    * make use of common.CopyBytes
    jwasinger committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    d8ada03 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2022

  1. core/blockchain: downgrade tx indexing and unindexing logs (ethereum#…

    …25832)
    
    core/blockchain: downgrade tx indexing and unindexing logs from info to debug
    
    If a user has a finite tx lookup limit, they will see an "unindexing" info level log each time a block is imported. This information might help a user understand that they are removing the index each block and some txs may not be retrievable by hash, but overall it is generally more of a nuisance than a benefit. This change downgrades the log to a debug log.
    lightclient committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    338bb2e View commit details
    Browse the repository at this point in the history
  2. eth/tracers: fix trace config for TraceCall (ethereum#25821)

    Co-authored-by:  AtomicAzzaz  <AtomicAzzaz@users.noreply.github.com>
    Co-authored-by:  ewile <ewile@users.noreply.github.com>
    3 people committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    5d11d38 View commit details
    Browse the repository at this point in the history
  3. eth/catalyst: add locking around newpayload (ethereum#25816)

    Sometimes we get stuck on db compaction, and the CL re-issues the "same" command to us multiple times. Each request get stuck on the same place, in the middle of the handler.
    
    This changes makes it so we do not reprocess the same payload, but instead detects it early.
    holiman committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    6eb8f32 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    400ab0d View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2022

  1. cmd/utils: make --authrpc.jwtsecret a DirectoryFlag (ethereum#25849)

    Signed-off-by: Delweng <delweng@gmail.com>
    jsvisa committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    6215b92 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2022

  1. eth/protocols/snap: make log messages more clear that sync is ongoing (

    …ethereum#25837)
    
    * eth/protocols/snap: make log messages more clear that sync is ongoing
    
    * Update sync.go
    
    Co-authored-by: Felix Lange <fjl@twurst.com>
    holiman and fjl committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    fb500d1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    220bdd3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e6d4aed View commit details
    Browse the repository at this point in the history
  4. internal/version: use gitCommit injection in version handling code (e…

    …thereum#25851)
    
    This changes the CI build to store the git commit and date into package
    internal/version instead of package main. Doing this essentially merges our
    two ways of tracking the go-ethereum version into a single place, achieving
    two objectives:
    
    - Bad block reports, which use version.Info(), will now have the git commit
      information even when geth is built in an environment such as
      launchpad.net where git access is unavailable.
    
    - For geth builds created by `go build ./cmd/geth` (i.e. not using `go run
      build/ci.go install`), git information stored by the go tool is now used
      in the p2p node name as well as in `geth version` and `geth
      version-check`.
    fjl committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    65f3c1b View commit details
    Browse the repository at this point in the history
  5. cmd/abigen: change --exc to exclude by type name (ethereum#22620)

    The abigen exclusion pattern, previously on the form "path:type", now supports wildcards. Examples "*:type" to exclude a named type in all files, or "/path/to/foo.sol:*" all types in foo.sol.
    sebastianst committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    e878067 View commit details
    Browse the repository at this point in the history
  6. tests, les, eth: remove mentions of deprecated Morden testnet (ethere…

    …um#23570)
    
    * remove morden
    
    * Update commons.go
    
    * Update handler.go
    
    * empty commit to make appveyor happy
    Zachinquarantine committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    9b35f3f View commit details
    Browse the repository at this point in the history
  7. all: clean up the configs for pruner and snapshotter (ethereum#22396)

    This PR cleans up the configurations for pruner and snapshotter by passing a config struct.
    
    And also, this PR disables the snapshot background generation if the chain is opened in "read-only" mode. The read-only mode is necessary in some cases. For example, we have a list of commands to open the etheruem node in "read-only" mode, like export-chain. In these cases, the snapshot background generation is non expected and should be banned explicitly.
    rjl493456442 committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    3da42f8 View commit details
    Browse the repository at this point in the history
  8. cmd/puppeth, cmd/utils: finalize removal of gasTarget flag (ethereum#…

    …24370)
    
    This PR fully removes the --miner.gastarget flag, as previously it was only hidden from the geth --help command, but could still be used.
    Zachinquarantine committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    15b4a4b View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2022

  1. core/types: improve accuracy of header.Size() (ethereum#25859)

    The header.Size() method did not take the basefee into account.
    zhiqiangxu committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    367e605 View commit details
    Browse the repository at this point in the history
  2. eth/tracers: pad memory slice on OOB case (ethereum#25213)

    * eth/tracers: pad memory slice on oob case
    
    * eth/tracers/js: fix testfailure due to err msg capitalization
    
    Co-authored-by: Martin Holst Swende <martin@swende.se>
    s1na and holiman committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    4dc212d View commit details
    Browse the repository at this point in the history
  3. cmd/faucet: fix readme typos (ethereum#25867)

    * Fix: typos
    
    Fix: typos
    
    * Undo change
    
    Undo change
    omahs committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    a3c6d1d View commit details
    Browse the repository at this point in the history
  4. core: fix datarace in txpool, fixes ethereum#25870 and ethereum#25869 (

    …ethereum#25872)
    
    core: fix datarace in txpool pendingnoce, fixes ethereum#25870
    holiman committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    e004e7d View commit details
    Browse the repository at this point in the history
  5. eth/downloader, les/downloader: fix subtle flaw in queue delivery (et…

    …hereum#25861)
    
    * fix queue.deliver
    
    * les/downloader: fix queue.deliver
    
    Co-authored-by: Martin Holst Swende <martin@swende.se>
    zhiqiangxu and holiman committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    b32d203 View commit details
    Browse the repository at this point in the history
  6. core/vm: better handle error on eip activation check (ethereum#25131)

    * core/vm: correct logic for eip check of NewEVMInterpreter
    
    * refactor
    qinglin89 committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    c55c56c View commit details
    Browse the repository at this point in the history
  7. cmd/geth: make dumpgenesis load genesis datadir if it exists (ethereu…

    …m#25135)
    
    `geth dumpgenesis` currently does not respect the content of the data directory. Instead, it outputs the genesis block created by command-line flags. This PR fixes it to read the genesis from the database, if the database already exists.
    
    
    Co-authored-by: Martin Holst Swende <martin@swende.se>
    jwasinger and holiman committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    7227c9e View commit details
    Browse the repository at this point in the history
  8. tests: fix state test error checking (ethereum#25702)

    Some tests define an 'expectException' error but the tests runner does not check for conditions where this test value is filled (error expected) but in which no error is returned by the test runner.
    
    An example of this scenario is GeneralStateTests/stTransactionTest/HighGasPrice.json, which expects a 'TR_NoFunds' error, but the test runner does not return any error.
    
    Signed-off-by: meows <b5c6@protonmail.com>
    meowsbits committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    3ec6fe6 View commit details
    Browse the repository at this point in the history
  9. eth/tracers: use gencodec for native tracers (ethereum#25637)

    The call tracer and prestate tracer store data JSON-encoded in memory. In order to support alternative encodings (specifically RLP), it's better to keep data a native format during tracing. This PR does marshalling at the end, using gencodec.
    
    OBS! 
    This PR changes the call tracer result slightly:
    
    -  Order of type and value fields are changed (should not matter). 
    -  Output fields are completely omitted when they're empty (no more output: "0x"). Previously, this was only _sometimes_ omitted (e.g. when call ended in a non-revert error) and otherwise 0x when the output was actually empty.
    s1na committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    fc3e6d0 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2022

  1. cmd, core, eth, les, light: track deleted nodes (ethereum#25757)

    * cmd, core, eth, les, light: track deleted nodes
    
    * trie: add docs
    
    * trie: address comments
    
    * cmd, core, eth, les, light, trie: trie id
    
    * trie: add tests
    
    * trie, core: updates
    
    * trie: fix imports
    
    * trie: add utility print-method for nodeset
    
    * trie: import err
    
    * trie: fix go vet warnings
    
    Co-authored-by: Martin Holst Swende <martin@swende.se>
    rjl493456442 and holiman committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    bff84a9 View commit details
    Browse the repository at this point in the history
  2. eth: return state error via GetEVM (ethereum#25876)

    * make vmError more useful
    
    * fix for review
    
    * Update api.go
    
    * revert calling site
    
    Co-authored-by: rjl493456442 <garyrong0905@gmail.com>
    zhiqiangxu and rjl493456442 committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    13e6985 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    80cc34a View commit details
    Browse the repository at this point in the history
  4. ethclient/gethclient: fix bugs in override object encoding (ethereum#…

    …25616)
    
    This fixes a bug where contract code would be overridden to empty code ("0x")
    when the Code field of OverrideAccount was left nil. The change also cleans up
    the encoding of overrides to only send necessary fields, and improves documentation.
    
    Fixes ethereum#25615
    
    Co-authored-by: Felix Lange <fjl@twurst.com>
    Co-authored-by: Martin Holst Swende <martin@swende.se>
    3 people committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    1a63a76 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2022

  1. trie, eth/protocols/snap: less tiny db-writes during trie-healing (et…

    …hereum#25681)
    
    This PR prevent making tiny writes during state healing, by only performing the batch-write if the accumulated data is large enough to be meaningful.
    holiman committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    456b187 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1743e61 View commit details
    Browse the repository at this point in the history
  3. tests: report mgas/s metric in evm benchmarks (ethereum#25700)

    * test(state): report mgas/s metric in EVM benchmark
    
    * revert testdata submodule update
    
    * aggregate mgas/s results
    
    * calculate elapsed time better
    
    * tests: benchmarks - handle access list + take refund into account
    
    Co-authored-by: Martin Holst Swende <martin@swende.se>
    shekhirin and holiman committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    53d68fe View commit details
    Browse the repository at this point in the history
  4. core/vm: minor trivial clean up (ethereum#25880)

    * dropped `vm.keccakState` for `crypto.KeccakState`
    
    * cleaned up `OpCode.IsPush()`
    lmittmann committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    2b1299b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    85aafcf View commit details
    Browse the repository at this point in the history
  6. internal/ethapi: handle odd length hex in decodeHash (ethereum#25883)

    This change adds zero-padding (prefix) of odd nibbles in the decodeHash function. 
    
    Co-authored-by: ty <ty@oncoder.com>
    f01c5700 and ty committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    88132af View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2022

  1. core: rework tx indexer (ethereum#25723)

    This PR reworks tx indexer a bit. Compared to the original version, one scenario is no longer handled - upgrading  from legacy geth without indexer support. 
    
    The tx indexer was introduced in 2020 and have been present through hardforks, so it can be assumed that all Geth nodes have tx indexer already. So we can simplify the tx indexer logic a bit:
    
    -    If the tail flag is not present, it means node is just initialized may or may not with an ancient store attached. In this case all blocks are regarded as unindexed
    -   If the tail flag is present, it means blocks below tail are unindexed, blocks above tail are indexed
    
    This change also address some weird cornercases that could make the indexer not work after a crash.
    rjl493456442 committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    052c634 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c2918c2 View commit details
    Browse the repository at this point in the history
  3. eth/tracers: remove revertReasonTracer, add revert reason to callTrac…

    …er (ethereum#25508)
    
    * eth/tracers: add revertReason to callTracer
    
    * update callframe gen json
    
    * add revertal to calltrace test
    s1na committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    ff1f492 View commit details
    Browse the repository at this point in the history
  4. accounts/abi/bind: parse ABI only once on bind (ethereum#25574)

    * accounts/abi/bind: parse ABI once on bind
    
    * accounts/abi/bind: suppress 'imported and not used' error for abi package
    mikhailv committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    f651d6d View commit details
    Browse the repository at this point in the history
  5. internal/flags: fix issue with stringslice migration (ethereum#25830)

    This fixes a cornercase bug where the flag migration would mess
    up the value of StringSlice flags.
    holiman committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    07e0704 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2022

  1. cmd/geth, cmd/utils: geth attach with custom headers (ethereum#25829)

    This PR makes it possible to set custom headers, in particular for two scenarios: 
    
    - geth attach
    - geth commands which can use --remotedb, e..g geth db inspect
    
    The ability to use custom headers is typically useful for connecting to cloud-apis, e.g. providing an infura- or alchemy key, or for that matter access-keys for environments behind cloudflare.  
    
    Co-authored-by: Felix Lange <fjl@twurst.com>
    holiman and fjl committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    ea26fc8 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2022

  1. core/types: add a testcase to TestLegacyReceiptDecoding (ethereum#25909)

    add a testcase to TestLegacyReceiptDecoding
    zhiqiangxu committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    a724163 View commit details
    Browse the repository at this point in the history
  2. eth/protocols/snap: serve snap requests when possible (ethereum#25644)

    This PR makes it so that the snap server responds to trie heal requests when possible, even if the snapshot does not exist. The idea being that it might prolong the lifetime of a state root, so we don't have to pivot quite as often.
    holiman committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    f61b50b View commit details
    Browse the repository at this point in the history
  3. eth, miner: add timeout for building sealing block (ethereum#25407)

    * eth, miner: add timeout for building sealing block
    
    * eth, cmd, miner: add newpayloadtimeout flag
    
    * eth, miner, cmd: address comments
    
    * eth, miner: minor fixes
    
    Co-authored-by: Martin Holst Swende <martin@swende.se>
    rjl493456442 and holiman committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    1913b50 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. all: fix docstrings

    holiman committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    ee301c7 View commit details
    Browse the repository at this point in the history
  2. Merge pull request ethereum#25924 from holiman/comments_fix

    all: fix docstrings
    karalabe committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    4f7a425 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e14164d View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2022

  1. eth/tracers: add diffMode to prestateTracer (ethereum#25422)

    Backwards compatibility warning: The result will from now on omit empty fields instead
    of including a zero value (e.g. no more `balance: '0x'`).
    
    The prestateTracer will now take an option `diffMode: bool`. In this mode
    the tracer will output the pre state and post data for the modified parts of state.
    Read-only accesses will be completely omitted. Creations (be it account or slot)
    will be signified by omission in the `pre` list and inclusion in `post`. Whereas
    deletion (be it account or slot) will be signified by inclusion in `pre` and omission
    in `post` list.
    
    Signed-off-by: Delweng <delweng@gmail.com>
    jsvisa committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    5d52a35 View commit details
    Browse the repository at this point in the history
  2. eth/traces: add state limit (ethereum#25812)

    This PR introduces a new mechanism in chain tracer for preventing creating too many trace states.
    
    The workflow of chain tracer can be divided into several parts:
    
    - state creator generates trace state in a thread
    - state tracer retrieves the trace state and applies the tracing on top in another thread
    - state collector gathers all result from state tracer and stream to users
    
    It's basically a producer-consumer model here, while if we imagine that the state producer generates states too fast, then it will lead to accumulate lots of unused states in memory. Even worse, in path-based state scheme it will only keep the latest 128 states in memory, and the newly generated state will invalidate the oldest one by marking it as stale.
    
    The solution for fixing it is to limit the speed of state generation. If there are over 128 states un-consumed in memory, then the creation will be paused until the states are be consumed properly.
    rjl493456442 committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    e50aeac View commit details
    Browse the repository at this point in the history
  3. core/bloombits: speed up windows-test (ethereum#25844)

    core/bloombits: remove micro-sleep
    holiman committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    deead99 View commit details
    Browse the repository at this point in the history
  4. core, ethclient/gethclient: improve flaky tests (ethereum#25918)

    * ethclient/gethclient: improve time-sensitive flaky test
    
    * eth/catalyst: fix (?) flaky test
    
    * core: stop blockchains in tests after use
    
    * core: fix dangling blockchain instances
    
    * core: rm whitespace
    
    * eth/gasprice, eth/tracers, consensus/clique: stop dangling blockchains in tests
    
    * all: address review concerns
    
    * core: goimports
    
    * eth/catalyst: fix another time-sensitive test
    
    * consensus/clique: add snapshot test run function
    
    * core: rename stop() to stopWithoutSaving()
    
    Co-authored-by: Felix Lange <fjl@twurst.com>
    holiman and fjl committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    067bac3 View commit details
    Browse the repository at this point in the history
  5. node: prevent exposing engine API on unauthenticated endpoint (ethere…

    …um#25939)
    
    * node: prevent exposing engine API on unauthenticated endpoint
    
    * node: improve RPC setup
    fjl committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    9cddfe9 View commit details
    Browse the repository at this point in the history
  6. eth/filters: fix for eth_getLogs failing with finalized- and safe tag (

    …ethereum#25922)
    
    Prior to this change, f.begin (and possibly end) stay negative, leading to strange results later in the code. With this change, filters using "safe" and "finalized" block produce results consistent w/ the overall behavior of this RPC method.
    
    Co-authored-by: Martin Holst Swende <martin@swende.se>
    ryanschneider and holiman committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    df2b3cd View commit details
    Browse the repository at this point in the history
  7. cmd/geth: fix help output issues (ethereum#25941)

    This update resolves an issue where StringSliceFlag would not be
    rendered correctly in help output + mention that -H can be used multiple times
    
    Co-authored-by: Martin Holst Swende <martin@swende.se>
    fjl and holiman committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    5647516 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. accounts/usbwallet: support Ledger Nano S Plus and FTS (ethereum#25933)

    * usbwallet support Ledger Nano S Plus
    
    * accounts/usbwallet: add definitions + ref to ledger docs
    
    Co-authored-by: Martin Holst Swende <martin@swende.se>
    lochjin and holiman committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    7eafbec View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5a02b2d View commit details
    Browse the repository at this point in the history
  3. cmd/geth, core: fix typo in comment (ethereum#25954)

    * fix typo on comment
    
    * typo "can't accept"
    molecula451 committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    1c737e8 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. Configuration menu
    Copy the full SHA
    28d076d View commit details
    Browse the repository at this point in the history
  2. core/types: add more context around ErrInvalidChainID (ethereum#25367)

    This changes the error message for mismatching chain ID to show
    the given and expected value. Callers expecting this error must be
    changed to use errors.Is.
    MariusVanDerWijden committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    a007ab7 View commit details
    Browse the repository at this point in the history
  3. common/math: optimized modexp (+ fuzzer) (ethereum#25525)

    This adds a 
    * core/vm, tests: optimized modexp + fuzzer
    
    * common/math: modexp optimizations
    
    * core/vm: special case base 1 in big modexp
    
    * core/vm: disable fastexp
    holiman committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    bed3b10 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e257b3a View commit details
    Browse the repository at this point in the history
  5. node: drop support for static & trusted node list files (ethereum#25610)

    This changes the node setup to ignore datadir files
    
        static-nodes.json
        trusted-nodes.json
    
    When these files are present, it an error will be printed to the log.
    s1na committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    3630caf View commit details
    Browse the repository at this point in the history
  6. accounts/keystore: faster tests (ethereum#25827)

    This PR removes some optimistic tests -- a'la "do something,
    wait a while, and hope it has trickled through and continue" -- and
    instead uses some introspection to ensure that prerequisites are met.
    holiman committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    eaf095c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    010f47f View commit details
    Browse the repository at this point in the history
  8. eth/filters, ethclient/gethclient: add fullTx option to pending tx fi…

    …lter (ethereum#25186)
    
    This PR adds a way to subscribe to the _full_ pending transactions, as opposed to just being notified about hashes. 
    
    In use cases where client subscribes to newPendingTransactions and gets txhashes only to then request the actual transaction, the caller can now shortcut that flow and obtain the transactions directly. 
    
    
    Co-authored-by: Felix Lange <fjl@twurst.com>
    lmittmann and fjl committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    5b1a04b View commit details
    Browse the repository at this point in the history
  9. go.mod: upgrade github.com/dop251/goja (ethereum#25955)

    This upgrade pulls in a fix to handling of 'continue' in loops.
    ucwong committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    9207e34 View commit details
    Browse the repository at this point in the history
  10. eth/tracers: fix the issue of panic in prestate with diffmode (ethere…

    …um#25957)
    
    In some cases, inner contract creation may not be successful, and an inner contract was not created. This PR fixes a crash that could occur when doing tracing in such situations.
    jsvisa committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    c776a98 View commit details
    Browse the repository at this point in the history
  11. Revert "go.mod: upgrade github.com/dop251/goja" (ethereum#25975)

    Revert "go.mod: upgrade github.com/dop251/goja (ethereum#25955)"
    
    This reverts commit 9207e34.
    holiman committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    fb75f11 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2022

  1. common/math, tests/fuzzers: use big.Int clone (ethereum#26006)

    * common/math, tests/fuzzers: use big.Int clone
    
    * common/math: license
    holiman committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    15b7e0b View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. cmd/utils: enable snapshot generation in import-mode (ethereum#25990)

    This PR fixes a regression causing snapshots not to be generated in "geth --import" mode.  It also fixes the geth export command to be truly readonly, and adds a new test for geth export.
    holiman committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    6069d82 View commit details
    Browse the repository at this point in the history
  2. core/rawdb: refactor db key prefix (ethereum#26000)

    Co-authored-by: seven <seven@nodereal.io>
    s7v7nislands and seven committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    d86fe26 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b9ba6f6 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. internal/ethapi, accounts/abi/backends: use error defined in core (et…

    …hereum#26012)
    
    Co-authored-by: seven <seven@nodereal.io>
    s7v7nislands and seven committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    9b9a1b6 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. eth/tracers: fix the issue prestate missing existing contract state (e…

    …thereum#25996)
    
    The prestate tracer did not report accounts that existed at a given address prior to a contract being created at that address.
    
    Signed-off-by: Delweng <delweng@gmail.com>
    Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com>
    jsvisa and s1na committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    a404195 View commit details
    Browse the repository at this point in the history
  2. eth/tracers: simplify test framework (ethereum#25973)

    Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com>
    holiman and s1na committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    5f70f9f View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. Configuration menu
    Copy the full SHA
    a6dda03 View commit details
    Browse the repository at this point in the history
  2. Merge pull request ethereum#26038 from karalabe/split-txpool

    all: refactor txpool into it's own package in prep for 4844
    karalabe committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    a2b7481 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. Configuration menu
    Copy the full SHA
    68ba845 View commit details
    Browse the repository at this point in the history
  2. Merge pull request ethereum#26044 from karalabe/rename-typed-tx-files

    core/types: rename tx files to group them better together
    karalabe committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    5bed24d View commit details
    Browse the repository at this point in the history
  3. core, eth: for types with accurate size calcs, return uint64, not flo…

    …at (ethereum#26046)
    
    * core, eth: for types with accurate size calcs, return uint64, not float
    
    * core/types: proper tx size tests
    
    * core/types: extend tx size test with decoded sizes, fix error
    
    * core/txpool: fix linter
    
    Co-authored-by: Martin Holst Swende <martin@swende.se>
    karalabe and holiman committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    c4a6621 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1d0c4e2 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. Merge pull request ethereum#26049 from sandakersmann/master

    build: upgrade -dlgo version to Go 1.19.2
    karalabe committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    7496ad8 View commit details
    Browse the repository at this point in the history
  2. accounts/scwallet: fix keycard data signing error (ethereum#25331)

    accounts/scwallet: fix keycard data signing
    gballet committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    0c66d97 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4984c4e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9d795d0 View commit details
    Browse the repository at this point in the history
  5. eth/filters: change filter block to be by-ref (ethereum#26054)

    This PR changes the block field in the filter to be a pointer, to disambiguate between empty hash and no hash
    holiman committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    a1fc0d8 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. core/rawdb: refactor db inspector for extending multiple ancient store (

    ethereum#25896)
    
    This PR ports a few changes from PBSS:
    
    - Fix the snapshot generator waiter in case the generation is not even initialized
    - Refactor db inspector for ancient store
    rjl493456442 committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    60e30a9 View commit details
    Browse the repository at this point in the history
  2. cmd/evm: calc base fee if parent data is present (ethereum#26051)

    Currently, in order to chain together sequential valid t8n transitions the caller must manually calculate the block base fee. This PR adds support for the necessary parent fee market data to calculate the base fee for the current transition.
    
    Concretely, env is extended to accept the following:
    
        parentBaseFee
        parentGasUsed
        parentGasLimit
    
    Example usage can be found in ./cmd/evm/testdata/25.
    
    Co-authored-by: Martin Holst Swende <martin@swende.se>
    lightclient and holiman committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    fbdeff9 View commit details
    Browse the repository at this point in the history
  3. eth/tracers: fix gasUsed for native and JS tracers (ethereum#26048)

    * eth/tracers: fix gasUsed in call tracer
    
    * fix js tracers gasUsed
    
    * fix legacy prestate tracer
    
    * fix restGas in test
    
    * drop intrinsicGas field from js tracers
    s1na committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    0f49422 View commit details
    Browse the repository at this point in the history
  4. cmd, eth: implement full-sync tester (ethereum#26035)

    This PR adds a parameter to startup, --synctarget. The synctarget flag is a developer-flag, that can be useful in some scenarios as a replacement for a CL node. It defines a fixed block sync target:
    
    geth --syncmode=full --synctarget=./block_15816882.hex_rlp 
    
    The --synctarget is only made available during syncmode=full
    rjl493456442 committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    2c1af8b View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2022

  1. rpc: update docstring (ethereum#26072)

    Co-authored-by: seven <seven@nodereal.io>
    s7v7nislands and seven committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    fb4a97f View commit details
    Browse the repository at this point in the history
  2. Fix trace call for inner reverts (ethereum#25971)

    Inner call reverts will now return the reason similar to the top-level call. Separately, if top-level call is of type CREATE and it fails, its `to` field will now be cleared to `0x00...00` instead of being set to the created address.
    ngotchac committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    5329aa3 View commit details
    Browse the repository at this point in the history
  3. eth: implement eth/68 (ethereum#25980)

    * eth: implement eth/68
    
    * eth/protocols/eth: added tx size to announcement
    
    * eth/protocols/eth: check equal lengths on receiving announcement
    
    * eth/protocols/eth: add +1 to tx size because of the type byte
    
    * eth: happy lint, add eth68 tests, enable eth68
    
    * eth: various nitpick fixes on eth/68
    
    * eth/protocols/eth: fix announced tx size wrt type byte
    
    Co-authored-by: MariusVanDerWijden <m.vanderwijden@live.de>
    Co-authored-by: Péter Szilágyi <peterke@gmail.com>
    3 people committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    b0d4433 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2022

  1. eth/tracers: add withLog to callTracer (ethereum#25991)

    In some cases, it is desirable to capture what is triggered by each trace, when using the `callTracer`. For example: call `USDT.transfer` will trigger a `Transfer(from, to, value)` event.
    
    This PR adds the option to capture logs to the call tracer, by specifying `{"withLog": true}` in the tracerconfig. 
    Any logs belonging to failed/reverted call-scopes are removed from the output, to prevent interpretation mistakes.
    
    Signed-off-by: Delweng <delweng@gmail.com>
    Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com>
    jsvisa and s1na committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    8e69622 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0c40df5 View commit details
    Browse the repository at this point in the history
  3. accounts/abi: return error on fixed bytes with size larger than 32 by…

    …tes (ethereum#26075)
    
    * fixed bytes with size larger than 32 bytes is not allowed
    
    * add testcase
    zhiqiangxu committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    8578eb2 View commit details
    Browse the repository at this point in the history
  4. consensus/ethash: fix typo (ethereum#26016)

    fix typo
    zhiqiangxu committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    2b65219 View commit details
    Browse the repository at this point in the history
  5. docs/postmortems: remove wrong parentheses (ethereum#26066)

    Removed parentheses in line 71 because line 80 doesn't have them either.
    SebastianSupreme committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    2415911 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. miner, eth: implement recommit mechanism for payload building (ethere…

    …um#25836)
    
    * miner, eth: implement recommit for payload building
    
    * miner: address comments from marius
    rjl493456442 committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    a2a144c View commit details
    Browse the repository at this point in the history
  2. miner: fail early if core.NewBlockChain fails (ethereum#26079)

    don't ignore errors returned by core.NewBlockChain when initializing tests
    roberto-bayardo committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    24f08ec View commit details
    Browse the repository at this point in the history
  3. p2p/discover: fix handling of distance 256 in lookupDistances (ethere…

    …um#26087)
    
    Noticed that lookupDistances for FINDNODE requests didn't consider 256 a valid
    distance. This is actually part of the example in the comment above the
    function, surprised that wasn't tested before.
    jtraglia committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    621b423 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4a81e5a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    05037ea View commit details
    Browse the repository at this point in the history
  6. cmd/clef: add list-accounts and list-wallets to CLI (ethereum#26080)

    This commit adds support for two new commands to clef, making it possible to list accounts / wallets from the command-line-interface. 
    
    Co-authored-by: Martin Holst Swende <martin@swende.se>
    jmcook1186 and holiman committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    f3a005f View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. Configuration menu
    Copy the full SHA
    19bf99f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c77e39b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9a4e8e2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8f94acc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a0731a0 View commit details
    Browse the repository at this point in the history