Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF132 Add webgl2rendering unpackColorSpace #36257

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Oct 8, 2024

FF123 adds support for gl.unpackColorSpace and drawingBufferColorSpace(). This copies the docs from the WebGLRenderingContext to WebGL2RenderingContext.

Note that the docs story in WebGL is a bit confusing. WebGL2RenderingContext is built on top of WebGLRenderingContext and includes everything it has plus some additions (new stuff and new additions to the old stuff). But for docs mostly the second version does not duplicate the original - but there are some exceptions. I think we should duplicate everything because it makes things more sane and the sidebar makes more sense.

Anyway, given that there was some duplication I chose to copy these two as well.

This is part of #36112

@hamishwillee hamishwillee requested a review from a team as a code owner October 8, 2024 00:14
@hamishwillee hamishwillee requested review from sideshowbarker and removed request for a team October 8, 2024 00:14
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Preview URLs

Flaws (2)

Note! 3 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/WebGL2RenderingContext/unpackColorSpace
Title: WebGL2RenderingContext: unpackColorSpace property
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/API/WebGL2RenderingContext/texImage2D
    • Can't resolve /en-US/docs/Web/API/WebGL2RenderingContext/texSubImage2D
External URLs (4)

URL: /en-US/docs/Web/API/WebGL2RenderingContext/unpackColorSpace
Title: WebGL2RenderingContext: unpackColorSpace property


URL: /en-US/docs/Web/API/WebGL2RenderingContext/drawingBufferColorSpace
Title: WebGL2RenderingContext: drawingBufferColorSpace property

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant