Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: num_dir_sectors #53

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Conversation

francisdb
Copy link
Contributor

Correctly update file header num_dir_sectors when new directory sectors are added.

fixes #52

@francisdb francisdb force-pushed the fix/num_dir_sectors branch 2 times, most recently from ef72c7e to d60e00d Compare April 5, 2024 22:05
src/internal/directory.rs Outdated Show resolved Hide resolved
@mdsteele
Copy link
Owner

mdsteele commented Apr 7, 2024

Looks like the linter is unhappy, so the tests didn't run. I just fixed the config (I think) so that next time the tests can still run even if the linter fails.

@francisdb
Copy link
Contributor Author

@mdsteele applied cargo fmt

@francisdb
Copy link
Contributor Author

Can I get a CI approval?

@mdsteele mdsteele merged commit 88a71d3 into mdsteele:master Apr 9, 2024
4 checks passed
@mdsteele
Copy link
Owner

mdsteele commented Apr 9, 2024

Thanks for the fix!

@francisdb francisdb deleted the fix/num_dir_sectors branch April 9, 2024 14:31
@francisdb
Copy link
Contributor Author

francisdb commented Apr 9, 2024

Any plans for a release?
I can recommend https://github.com/MarcoIeni/release-plz/

@mdsteele
Copy link
Owner

Published as v0.10.0.

@francisdb
Copy link
Contributor Author

Published as v0.10.0.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Corrupted file / Paths disappear when reading using ole32.dll after copy
2 participants