Allow a DIFAT sector to be padded with zeroes #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks. (The new unit tests are much appreciated.) |
|
Thanks for the PR and for merging. Would it be possible to do a release with this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove zeroes from the end of the DIFAT; it should be padded with FREE_SECTOR but 0 is seen in practice, specifically with Altium .SchLib files.
This could be simpler (to implement and test) by just trimming the DIFAT to
header.num_fat_sectorsin permissive mode, maybe with a check that only FREE_SECTOR or 0 is trimmed. I'd prefer to do it that way, but I'm not sure if that header field is considered unreliable; if that would be an acceptable fix let me know and I can put together a revised PR.Closes #41