Embedded video player #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FileField should store a relative path, to make their "url" attribute work
|
Thanks for the PR! This looks like an excellent addition and thanks for keeping it in the same code style. |
|
Thanks for this great project and the fast merging ! :) |
|
No problem. A bunch of stuff is in the slightly older Django way of doing things now so feel free to poke about if you like. This PR probably won't get released until I can fully test it as well as fix the container build so it might be a few days. |
|
No worries for a release, I'm running a dev version. Let me know if you find issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an embedded video player and a download link to videos in the media view.
1st commit fixes the handling of Django's FileField (see https://docs.djangoproject.com/en/4.1/topics/files/)
2nd commit uses Nginx X-Accel-Redirect feature to offload the video streaming (see https://www.nginx.com/resources/wiki/start/topics/examples/x-accel/#x-accel-redirect)