Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete files on disk #426

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

sparklesmcfadden
Copy link
Contributor

Adds option to delete files on disk when removing a media item from TubeSync. Restores previously-removed code in signals.py (as mentioned in #206) and gates it behind an option.

@meeb
Copy link
Owner

meeb commented Oct 23, 2023

Thanks for the contribution! This looks reasonable to me. There also may be subtitles and metadata files stored on disk as well (vtt and nfo files etc.). If you could update this to also clean those up when media is deleted I'll merge this into the next release.

meeb added a commit that referenced this pull request Jan 17, 2024
@meeb meeb merged commit 805a0ee into meeb:main Jan 17, 2024
@hunterpankey
Copy link

@meeb or @sparklesmcfadden Will we need to manually delete media/files for items that have already been removed from TubeSync, i.e., orphaned files on disk? I just updated and forced a reindex for a few channels and files aren't going away.

@meeb
Copy link
Owner

meeb commented Feb 28, 2024

Yes, if you've deleted the record of the media item in tubesync it won't be cleaned up on disk automatically. tubesync doesn't scan existing files for orphans and delete them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants