Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add attributesToSearchOn to IndexSearchRequest #779

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Add attributesToSearchOn to IndexSearchRequest #779

merged 2 commits into from
Oct 3, 2024

Conversation

wyz8883
Copy link

@wyz8883 wyz8883 commented Sep 23, 2024

PARAMETER

Pull Request

Related issue

“Fixes #<issue_number>”

What does this PR do?

  • ...When I use Non-federated multi-search, I find that I can't add attributesToSearchOn, I'm sure there is no this parameter in IndexSearchRequest.I added one attributesToSearchOn.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@curquiza curquiza changed the title THIS COMMIT WILL INDEXSEARCHREQUEST ADD ATTRIBUTESTOSEARCHON Add attributesToSearchOn to IndexSearchRequest Oct 3, 2024
curquiza
curquiza previously approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Oct 3, 2024

Merge conflict.

@curquiza curquiza linked an issue Oct 3, 2024 that may be closed by this pull request
Restrict search to the specified attributes #778
Closed
curquiza
curquiza approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@curquiza curquiza added the enhancement New feature or request label Oct 3, 2024
@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Oct 3, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit 1746603 into meilisearch:main Oct 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restrict search to the specified attributes
2 participants
@wyz8883 @curquiza