add overlay filter #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varsill
approved these changes
Feb 21, 2024
|
|
||
| alias Membrane.RawVideo | ||
|
|
||
| def_input_pad :input, accepted_format: %RawVideo{pixel_format: :I420} |
There was a problem hiding this comment.
Since we rely that heavy on the fact, that the YUV pixels are written in the planar format, perhaps it would be good to add a pixels_order: :planar | :semiplanar | :interleaved field to the RawVideo format?
There was a problem hiding this comment.
Doesn't I420 already mean it's planar? If not, maybe we could adhere to some common terminology, like v4l https://docs.kernel.org/userspace-api/media/v4l/pixfmt-yuv-planar.html? Adding more fields gives a combinatorial explosion of possibilities, some of which may not exist or not be used in practice
There was a problem hiding this comment.
You are right, I420 stands for fully planar ;) take a look here: https://wiki.videolan.org/YUV#Planar_formats
Co-authored-by: Łukasz Kita <lukasz.kita0@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.