This repository has been archived by the owner on Jun 27, 2022. It is now read-only.
Improve examples #18
Merged
Improve examples #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meqif
force-pushed
the
improve_examples
branch
from
e2f6479
to
24f562e
Compare
meqif
force-pushed
the
improve_examples
branch
from
24f562e
to
8c27edc
Compare
Using `unwrap` is bad practice in most cases. Code examples should not promote that practice, as they may induce the user into believing it's acceptable.
meqif
force-pushed
the
improve_examples
branch
from
215daa7
to
fbfa939
Compare
|
Rust 1.4 is finally here, yay! 🎉 |
|
Just a heads up as well. MIO is now windows compatible and works on stable as well :-) All very nice. It may help resource usage and code complexity? |
canndrew
pushed a commit
to canndrew/rust-utp
that referenced
this pull request
Mar 15, 2016
Use VecDeque for buffers instead of Vec.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve code examples in README and module documentation.
The improvements require
result_expect(rust-lang/rust#27277), which is available on Rust 1.4 onwards. Merge only when 1.4 is released as stable.