Fix 404, redirect old urls to prefix /registre_ads

mesads/app/urls.py

@@ -26,19 +26,6 @@
         staff_member_required(views.DashboardsDetailView.as_view()),
         name="app.dashboards.detail",
     ),
-    # When the user makes a request to become an ADSManager, we send an email to
-    # the administrator. This email used to contain a link to /admin_gestion.
-    # For backward compatibility, we redirect the user to the new URL
-    # /registre_ads/admin_gestion.
-    path(
-        "admin_gestion",
-        RedirectView.as_view(url="/registre_ads/admin_gestion", permanent=True),
-    ),
-    # Backward compatibility
-    path(
-        "gestion",
-        RedirectView.as_view(url="/registre_ads/gestion", permanent=True),
-    ),
     path(
         "registre_ads/admin_gestion",
         ads_manager_administrator_required(views.ADSManagerAdminView.as_view()),

mesads/middleware.py

@@ -0,0 +1,25 @@
+from django.shortcuts import redirect
+from django.urls import resolve
+from django.urls.exceptions import Resolver404
+
+
+class BackwardCompatibilityURLMiddleware:
+    """In the past, all the URLs of the app were in the root of the website and
+    only the ADS register existed. Now, the ADS register is in /registre_ads and
+    the other URLs are in /other subpaths. This middleware redirects the old
+    URLs to the new ones for backward compatibility.
+    """
+
+    def __init__(self, get_response):
+        self.get_response = get_response
+
+    def __call__(self, request):
+        response = self.get_response(request)
+        if response.status_code == 404:
+            url = f"/registre_ads{request.path}"
+            try:
+                resolve(url)
+            except Resolver404:
+                return response
+            return redirect(url, permanent=True)
+        return response

mesads/settings.py

@@ -130,6 +130,7 @@ def parse_env_bool(key, default):
     "django.contrib.auth.middleware.AuthenticationMiddleware",
     "django.contrib.messages.middleware.MessageMiddleware",
     "django.middleware.clickjacking.XFrameOptionsMiddleware",
+    "mesads.middleware.BackwardCompatibilityURLMiddleware",
 ]
 
 ROOT_URLCONF = "mesads.urls"