Add polymorphism to MetricSnapshot class #101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitorbaraujo
force-pushed
the
solid
branch
5 times, most recently
from
e7d19eb
to
c2ac56f
Compare
Removing if's in parent method and providing implementation in proper subclasses Signed-off-by: Pedro Ivo Andrade <andradepedroivo@gmail.com> Signed-off-by: Vitor Barbosa <vitornga15@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Open Closed Principle (OCP) from SOLID principles, we refactored the MetricSnapshot class so that the method
as_jsonis implemented in its subclasses (CompoundMetricSnapshot,HotspotMetricSnapshotandNativeMetricSnapshot), instead of checking the class in the parent method