Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IsEmpty query #226

Merged
merged 1 commit into from
Oct 2, 2015
Merged

Add IsEmpty query #226

merged 1 commit into from
Oct 2, 2015

Conversation

nkreipke
Copy link
Contributor

@nkreipke nkreipke commented Oct 2, 2015

Greetings!

This patch adds the IsEmpty query to the driver: http://rethinkdb.com/api/javascript/is_empty/

Kind regards,
Nico

@mfenniak
Copy link
Owner

mfenniak commented Oct 2, 2015

Hi @nkreipke! Thank-you for all the pull requests. I love receiving surprise pull requests. I'm a bit busy today, but I'll try to go through these each as soon as I can and, merge them where possible, and give you feedback otherwise. :-)

It would be great to have an automated test for this new IsEmpty query. Would you mind adding one? It would probably fit in well in rethinkdb-net-test/Integration/TableTests.cs.

@nkreipke
Copy link
Contributor Author

nkreipke commented Oct 2, 2015

I'll try to write a few tests for these later. Quite a bit busy myself :-)

@mfenniak mfenniak mentioned this pull request Oct 2, 2015
@mfenniak mfenniak merged commit 6065b21 into mfenniak:master Oct 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants