Fixed handling of DateTime.MinValue. Issue #240 #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 6d878131fb4b5b8f402bcd5b43c7b0afa2c03d77)
|
Sure, that change to the test makes sense; we just can't represent the long values with the same precision as the double. But, it looks like the same test failure you encountered in the long datum converter still exists in the unsigned long datum converter. Could you please fix that up too? Errors and Failures:
Other than that, this looks good to merge. If you can push a fix for that and the CI goes green, I'll merge it up. |
|
Ups forgot that one. It should be fixed now |
mfenniak
added a commit
that referenced
this pull request
Nov 22, 2015
Fixed handling of DateTime.MinValue. Issue #240
mfenniak
added a commit
that referenced
this pull request
Nov 22, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed long and ulong MaxValue and MinValue checks