Move parse package internally and modify Makefile

[mfridman]

Fix #131

This PR does a few things:

• moves the ./parse package into ./internal/parse
• add tools module to track golangci-lint
• minor updates to Makefile

[ccoVeille]

LGTM 👍

One question, you mention

add tools module to track golangci-lint

I didn't find this one. I saw changes in Makefile, but that's it.

Is it what you were talking about?

I thought I would see something about toolchain entry in go.mod or something like that

[egonelbre]

Any specific reason parse package was moved to internal? It's been quite helpful to write custom tools for analyzing/processing the test output.

[mfridman]

Any specific reason parse package was moved to internal? It's been quite helpful to write custom tools for analyzing/processing the test output.

Trying to get this project to a v1 state I wanted to refactor and make some breaking changes to that package. It was quite coupled to the tool itself so I want to clean that up a bit.

Happy to move it out of ./internal though if you think there's some use for it.

[mfridman]

LGTM 👍

One question, you mention

add tools module to track golangci-lint

I didn't find this one. I saw changes in Makefile, but that's it.

Is it what you were talking about?

I thought I would see something about toolchain entry in go.mod or something like that

I was experimenting with it (189a957), but at the end decided the project was way too simple so I reverted those changes and forgot to update the description. Ultimately waiting for golang/go#48429 to land to improve the story around tool deps.

[egonelbre]

Happy to move it out of ./internal though if you think there's some use for it.

Yeah, it does come up occasionally for me.

I sometimes use some other "internal" to indicate that it's not finalized, like github.com/mfridman/tparse/exp/parse or github.com/mfridman/tparse/private/parse.

But, yeah, I can keep using the older version if you want to clean up the parse package.

[mfridman]

Thanks for surfacing it, happy to move it back to the top level. There might be some fairly minor breaking changes, but my ultimate goal is to make it an off-the-shelf parsing library and nail down the returned results.